Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: add jedi-vim plugin #49589

Merged
merged 1 commit into from Nov 4, 2018
Merged

vimPlugins: add jedi-vim plugin #49589

merged 1 commit into from Nov 4, 2018

Conversation

schmittlauch
Copy link
Member

@schmittlauch schmittlauch commented Nov 1, 2018 •
edited

Motivation for this change

I need the jedi-vim vim plugin. As the vim-plugins/defaultnix differ heavily between master and release-18.09, I'll do 2 different PRs for each branch.

Things done

This plugin needs python3 support in vim, but no other addon seems to
care about verifying that vim is built accordingly, so I don't do that
as well.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • successfully used the packaged plug-in in my nixpkgs.vim_configurable
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@schmittlauch
vim-plugins: add jedi-vim plugin
18d3332 
This plugin needs python3 support in vim, but no other addon seems to
care about verifying that vim is built accordingly, so I don't do that
as well.
@schmittlauch schmittlauch mentioned this pull request Nov 1, 2018
Merged
9 tasks
@schmittlauch schmittlauch changed the title vim-plugins: add jedi-vim plugin vimPlugins: add jedi-vim plugin Nov 2, 2018
@schmittlauch
Copy link
Member Author

ping @jagajaga

andir
andir approved these changes Nov 4, 2018
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with nix repl and

:b (pkgs.neovim.override { withPython = true; configure.packages.myVimBundle.start = [ pkgs.vimPlugins.jedi-vim ]; })

Autocompletion just worked fine for me. 👍

@andir andir merged commit faa179d into NixOS:release-18.09 Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schmittlauch @andir @GrahamcOfBorg