Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flyway: 5.1.4 -> 5.2.1 #49609

Merged
merged 1 commit into from Nov 6, 2018
Merged

flyway: 5.1.4 -> 5.2.1 #49609

merged 1 commit into from Nov 6, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 1, 2018

Motivation for this change

Supersedes #48523 and make the tool actually runnable
Distribute only the community edition JARs which are the only ones under Apache 2.0 license
This also reduce closure size

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
$ nix path-info -S ./result
/nix/store/mh9vpyxw8068dxzdswj1yy29i5dfq90r-flyway-5.2.1          156906096

$ ./result/bin/flyway -v
Flyway Community Edition 5.2.1 by Boxfuse

@c0bw3b
flyway: 5.1.4 -> 5.2.1
ee09650 
Distribute only the community edition JARs which are the only ones under Apache 2.0 license
This also reduce closure size
@c0bw3b c0bw3b mentioned this pull request Nov 1, 2018
Closed
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: flyway

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flyway

Partial log (click to expand)

setting SOURCE_DATE_EPOCH to timestamp 1540373664 of file flyway-5.2.1/lib/community/flyway-core-5.2.1.jar
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bv6k987ji8xysvgvhxq20qipmg4vdrza-flyway-5.2.1
patching script interpreter paths in /nix/store/bv6k987ji8xysvgvhxq20qipmg4vdrza-flyway-5.2.1
checking for references to /build in /nix/store/bv6k987ji8xysvgvhxq20qipmg4vdrza-flyway-5.2.1...
/nix/store/bv6k987ji8xysvgvhxq20qipmg4vdrza-flyway-5.2.1

@xeji
Copy link
Contributor

xeji commented Nov 1, 2018

Let's check darwin build:
@GrahamcOfBorg build flyway

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: flyway

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: flyway

Partial log (click to expand)

unpacking source archive /nix/store/zddrl7iv27zxvbg3sf0gxwk102bwk76b-flyway-commandline-5.2.1.tar.gz
source root is flyway-5.2.1
setting SOURCE_DATE_EPOCH to timestamp 1540373664 of file flyway-5.2.1/lib/community/flyway-core-5.2.1.jar
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
patching script interpreter paths in /nix/store/q6p65imsz7m6il67va592ahc0mc0kgya-flyway-5.2.1
/nix/store/q6p65imsz7m6il67va592ahc0mc0kgya-flyway-5.2.1

@xeji
Copy link
Contributor

xeji commented Nov 1, 2018

cc @CMCDragonkai

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flyway

Partial log (click to expand)

setting SOURCE_DATE_EPOCH to timestamp 1540373664 of file flyway-5.2.1/lib/community/flyway-core-5.2.1.jar
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bv6k987ji8xysvgvhxq20qipmg4vdrza-flyway-5.2.1
patching script interpreter paths in /nix/store/bv6k987ji8xysvgvhxq20qipmg4vdrza-flyway-5.2.1
checking for references to /build in /nix/store/bv6k987ji8xysvgvhxq20qipmg4vdrza-flyway-5.2.1...
/nix/store/bv6k987ji8xysvgvhxq20qipmg4vdrza-flyway-5.2.1

@c0bw3b c0bw3b merged commit aed2dea into NixOS:master Nov 6, 2018
@c0bw3b c0bw3b deleted the pkg/flyway branch November 6, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @GrahamcOfBorg @xeji