Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.snapcast: init at 2.0.9 #49591

Merged
merged 2 commits into from
Nov 7, 2018
Merged

pythonPackages.snapcast: init at 2.0.9 #49591

merged 2 commits into from
Nov 7, 2018
+31 −1

Conversation

peterhoeg
Copy link
Member

Motivation for this change

HA supports snapcast!

Cc @dotlambda

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@peterhoeg peterhoeg requested a review from FRidh as a code owner November 1, 2018 14:59
@dotlambda
Copy link
Member

From https://github.com/happyleavesaoc/python-snapcast:

Control Snapcast in Python 3

@peterhoeg
Copy link
Member Author

Not sure if setting meta.broken really communicates the proper intent here. It's not that it's broken as much as it isn't supported which really is two different things.

@dotlambda
Copy link
Member

We do this by disabled = !isPy3k for python packages :)

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg eval

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build python2Packages.snapcast python3Packages.snapcast
@GrahamcOfBorg test home-assistant

@dotlambda
Copy link
Member

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.snapcast

The following builds were skipped because they don't evaluate on aarch64-linux: python2Packages.snapcast

Partial log (click to expand)

Installing collected packages: snapcast
Successfully installed snapcast-2.0.9
/build/snapcast-2.0.9
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/636hjh88l7xqc2idarff4cidwmqxr3cs-python3.6-snapcast-2.0.9
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/636hjh88l7xqc2idarff4cidwmqxr3cs-python3.6-snapcast-2.0.9/lib
patching script interpreter paths in /nix/store/636hjh88l7xqc2idarff4cidwmqxr3cs-python3.6-snapcast-2.0.9
checking for references to /build in /nix/store/636hjh88l7xqc2idarff4cidwmqxr3cs-python3.6-snapcast-2.0.9...
/nix/store/636hjh88l7xqc2idarff4cidwmqxr3cs-python3.6-snapcast-2.0.9

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.home-assistant

Partial log (click to expand)

killing hass (pid 597)

### home-assistant.log ###
2018-11-07 08:09:27 WARNING (MainThread) [homeassistant.bootstrap] Skipping pip installation of required modules. This may cause issues
2018-11-07 08:09:27 WARNING (MainThread) [homeassistant.components.http] legacy_api_password support has been enabled. If you don't require it, remove the 'api_password' from your http config.
2018-11-07 08:09:30 WARNING (MainThread) [hbmqtt.mqtt.protocol.handler] BrokerProtocolHandler Unhandled exception in reader coro: IncompleteReadError('0 bytes read on a total of 1 expected bytes',)

vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/wcavmynsv5p981p5vdbsycjdh4405lgs-vm-test-run-home-assistant

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.snapcast

The following builds were skipped because they don't evaluate on x86_64-linux: python2Packages.snapcast

Partial log (click to expand)

Installing collected packages: snapcast
Successfully installed snapcast-2.0.9
/build/snapcast-2.0.9
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cwi31r7jkixrlijcl91hf10c731ic8sm-python3.6-snapcast-2.0.9
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cwi31r7jkixrlijcl91hf10c731ic8sm-python3.6-snapcast-2.0.9/lib
patching script interpreter paths in /nix/store/cwi31r7jkixrlijcl91hf10c731ic8sm-python3.6-snapcast-2.0.9
checking for references to /build in /nix/store/cwi31r7jkixrlijcl91hf10c731ic8sm-python3.6-snapcast-2.0.9...
/nix/store/cwi31r7jkixrlijcl91hf10c731ic8sm-python3.6-snapcast-2.0.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.home-assistant

Partial log (click to expand)

killing hass (pid 631)

### home-assistant.log ###
2018-11-07 09:07:24 WARNING (MainThread) [homeassistant.bootstrap] Skipping pip installation of required modules. This may cause issues
2018-11-07 09:07:24 WARNING (MainThread) [homeassistant.components.http] legacy_api_password support has been enabled. If you don't require it, remove the 'api_password' from your http config.
2018-11-07 09:07:30 WARNING (MainThread) [hbmqtt.mqtt.protocol.handler] BrokerProtocolHandler Unhandled exception in reader coro: IncompleteReadError('0 bytes read on a total of 1 expected bytes',)

vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/ncmgkcfz765na3qr2x827zfra64zpdsd-vm-test-run-home-assistant

@dotlambda dotlambda merged commit ae50efe into NixOS:master Nov 7, 2018
@peterhoeg peterhoeg deleted the p/snap branch November 8, 2018 08:04
@peterhoeg peterhoeg restored the p/snap branch November 8, 2018 12:25
@peterhoeg peterhoeg deleted the p/snap branch March 18, 2019 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @dotlambda @GrahamcOfBorg