Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6460: [AI] Add start_date parameter for Random AIs on new game #6923

Merged
merged 1 commit into from Nov 1, 2018

Conversation

SamuXarick
Copy link
Contributor

No description provided.

@LordAro
Copy link
Member

LordAro commented Sep 30, 2018

As discussed, wait for Samu to work out how to amend a commit so that the [AI] can be moved after the :

@SamuXarick SamuXarick closed this Sep 30, 2018
@LordAro LordAro reopened this Sep 30, 2018
@SamuXarick SamuXarick changed the title Fix #6460 [AI]: add start_date parameter for Random AIs on new game Fix #6460: [AI] Add start_date parameter for Random AIs on new game Oct 3, 2018
@nielsmh
Copy link
Contributor

nielsmh commented Nov 1, 2018

Above change to commit message was made. I'm not sure what this patch actually does though, whether or not I have it applied I can configure the start delay for random AIs. I've tried stepping through the code and it seems to have absolutely no effect, a bunch of extra work for no purpose.

@SamuXarick
Copy link
Contributor Author

You can on the main menu, but not after starting a new game. The 'Configure' button is gray. I found out the issue was that the start_date parameter was not being created for random ais when starting a new game.

@nielsmh nielsmh merged commit 4703cd4 into OpenTTD:master Nov 1, 2018
@SamuXarick SamuXarick deleted the start_date-for-Random-AI branch January 14, 2019 19:34
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this pull request Jan 21, 2024
There was an issue with the start_date parameter for AIs. It did not let Random AIs to have their configure button clickable once the game has started, and this was due to the start_date not being pushed into the config.

But now that start_date is no longer in use, this workaround can be safely removed.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this pull request Jan 21, 2024
There was an issue with the start_date parameter for AIs. It did not let Random AIs to have their configure button clickable once the game has started, and this was due to the start_date not being pushed into the config.

But now that start_date is no longer in use since OpenTTD#10653, this workaround can be safely removed.
rubidium42 pushed a commit that referenced this pull request Jan 21, 2024
There was an issue with the start_date parameter for AIs. It did not let Random AIs to have their configure button clickable once the game has started, and this was due to the start_date not being pushed into the config.

But now that start_date is no longer in use since #10653, this workaround can be safely removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants