Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 0.33.6 -> 0.33.8 #49604

Merged
merged 1 commit into from Nov 4, 2018
Merged

matrix-synapse: 0.33.6 -> 0.33.8 #49604

merged 1 commit into from Nov 4, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Nov 1, 2018

Also reworked dependencies:

  • blist and ujson are marked as no longer needed
  • pytz has no mention throughout git log -p on synapse's repository
  • systemd and affinity are optional (but turned on by default)

cc @roblabla @Ralith

@GrahamcOfBorg test matrix-synapse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ekleog Ekleog mentioned this pull request Nov 1, 2018
Merged
9 tasks
@Ekleog
Copy link
Member Author

Ekleog commented Nov 1, 2018

Backport is at #49606

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

wrapping `/nix/store/14k69q04jivblpr09ic6lb3xsbwmj156-matrix-synapse-0.33.8/bin/synctl'...
wrapping `/nix/store/14k69q04jivblpr09ic6lb3xsbwmj156-matrix-synapse-0.33.8/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/14k69q04jivblpr09ic6lb3xsbwmj156-matrix-synapse-0.33.8/bin/hash_password'...
wrapping `/nix/store/14k69q04jivblpr09ic6lb3xsbwmj156-matrix-synapse-0.33.8/bin/homeserver'...
running install tests

-------------------------------------------------------------------------------

PASSED
pytestcachePhase

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

wrapping `/nix/store/ka1azgn6xb2xn108v89cchk4bjibdkya-matrix-synapse-0.33.8/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/ka1azgn6xb2xn108v89cchk4bjibdkya-matrix-synapse-0.33.8/bin/register_new_matrix_user'...
wrapping `/nix/store/ka1azgn6xb2xn108v89cchk4bjibdkya-matrix-synapse-0.33.8/bin/synapse_port_db'...
wrapping `/nix/store/ka1azgn6xb2xn108v89cchk4bjibdkya-matrix-synapse-0.33.8/bin/synctl'...
running install tests

-------------------------------------------------------------------------------

PASSED
pytestcachePhase

@Ralith
Copy link
Contributor

Ralith commented Nov 1, 2018 •
edited

Wasn't the affinity dependency removed entirely? IIRC word from @hawkowl was that its functionality was subsumed into some other package, and it's long-unmaintained.

@hawkowl
Copy link

hawkowl commented Nov 1, 2018 via email

@Ekleog
Copy link
Member Author

Ekleog commented Nov 2, 2018

OK thanks! I did most of my dependency-checking by grepping for the package names in the source, didn't notice the reference to affinity was in CHANGES.md :)

I've pushed updated packages to both this PR and the 18.09 backport.

@GrahamcOfBorg test matrix-synapse

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

serverpostgres: exit status 0
serversqlite: running command: sync
serversqlite: exit status 0
test script finished in 133.72s
cleaning up
killing serverpostgres (pid 597)
killing serversqlite (pid 609)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/rjmrn8c61asvm7r3s85sxs8j26bgn9c3-vm-test-run-matrix-synapse

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

/nix/store/ipjd4kw3df5z4lmkas3fa7vzsqjqnhm9-matrix-synapse-0.33.8

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

wrapping `/nix/store/mjxlhfgvi6md94qazf2203vzzwhxm8gg-matrix-synapse-0.33.8/bin/synctl'...
wrapping `/nix/store/mjxlhfgvi6md94qazf2203vzzwhxm8gg-matrix-synapse-0.33.8/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/mjxlhfgvi6md94qazf2203vzzwhxm8gg-matrix-synapse-0.33.8/bin/hash_password'...
wrapping `/nix/store/mjxlhfgvi6md94qazf2203vzzwhxm8gg-matrix-synapse-0.33.8/bin/homeserver'...
running install tests

-------------------------------------------------------------------------------

PASSED
pytestcachePhase

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

serverpostgres: exit status 0
serversqlite: running command: sync
serversqlite: exit status 0
test script finished in 108.62s
cleaning up
killing serverpostgres (pid 631)
killing serversqlite (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/lihqnl62xdcvj6v6jvxykw77fah8ph74-vm-test-run-matrix-synapse

@7c6f434c
Copy link
Member

7c6f434c commented Nov 2, 2018

Time to merge?

@Ekleog
Copy link
Member Author

Ekleog commented Nov 3, 2018

@7c6f434c Think so, as well as the backport :) Thanks!

@Ekleog
matrix-synapse: 0.33.6 -> 0.33.8
bb86056 
Also reworked dependencies:
 * blist and ujson are marked as no longer needed
 * pytz has no mention throughout `git log -p` on synapse's repository
 * systemd and affinity are optional (but turned on by default)
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

wrapping `/nix/store/2ildp3zmx7qwr66q0b50cia5xisahwyg-matrix-synapse-0.33.8/bin/synctl'...
wrapping `/nix/store/2ildp3zmx7qwr66q0b50cia5xisahwyg-matrix-synapse-0.33.8/bin/register_new_matrix_user'...
wrapping `/nix/store/2ildp3zmx7qwr66q0b50cia5xisahwyg-matrix-synapse-0.33.8/bin/homeserver'...
running install tests

-------------------------------------------------------------------------------

PASSED
pytestcachePhase
/nix/store/2ildp3zmx7qwr66q0b50cia5xisahwyg-matrix-synapse-0.33.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

wrapping `/nix/store/7pizav92lb0q3v9rgndd9n3892hbqkp9-matrix-synapse-0.33.8/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/7pizav92lb0q3v9rgndd9n3892hbqkp9-matrix-synapse-0.33.8/bin/register_new_matrix_user'...
wrapping `/nix/store/7pizav92lb0q3v9rgndd9n3892hbqkp9-matrix-synapse-0.33.8/bin/synapse_port_db'...
wrapping `/nix/store/7pizav92lb0q3v9rgndd9n3892hbqkp9-matrix-synapse-0.33.8/bin/synctl'...
running install tests

-------------------------------------------------------------------------------

PASSED
pytestcachePhase

@7c6f434c 7c6f434c merged commit 3e287ac into NixOS:master Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkowl hawkowl hawkowl left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ekleog @GrahamcOfBorg @Ralith @hawkowl @7c6f434c