Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minishift: 1.25.0 -> 1.26.1 #49610

Closed
wants to merge 1 commit into from
Closed

minishift: 1.25.0 -> 1.26.1 #49610

wants to merge 1 commit into from

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Nov 1, 2018 •
edited

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Bump minishift to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vdemeester
minishift: 1.25.0 -> 1.26.1
9cbcfab 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@xeji
Copy link
Contributor

xeji commented Nov 1, 2018

@GrahamcOfBorg build minishift

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: minishift

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: minishift

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c4r46h0x32zjfbgym0jbybd8x0l6g2l2-minishift-1.26.1-bin
shrinking /nix/store/c4r46h0x32zjfbgym0jbybd8x0l6g2l2-minishift-1.26.1-bin/bin/.minishift-wrapped
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c4r46h0x32zjfbgym0jbybd8x0l6g2l2-minishift-1.26.1-bin/bin
patching script interpreter paths in /nix/store/c4r46h0x32zjfbgym0jbybd8x0l6g2l2-minishift-1.26.1-bin
checking for references to /build in /nix/store/c4r46h0x32zjfbgym0jbybd8x0l6g2l2-minishift-1.26.1-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip

@xeji
Copy link
Contributor

xeji commented Nov 1, 2018

cc @fpletz

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: minishift

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nxpz7f6kv4jpjhg3n8r93472z2n012py-minishift-1.26.1-bin
shrinking /nix/store/nxpz7f6kv4jpjhg3n8r93472z2n012py-minishift-1.26.1-bin/bin/.minishift-wrapped
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nxpz7f6kv4jpjhg3n8r93472z2n012py-minishift-1.26.1-bin/bin
patching script interpreter paths in /nix/store/nxpz7f6kv4jpjhg3n8r93472z2n012py-minishift-1.26.1-bin
checking for references to /build in /nix/store/nxpz7f6kv4jpjhg3n8r93472z2n012py-minishift-1.26.1-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 25, 2018

Done in #50477

@c0bw3b c0bw3b closed this Nov 25, 2018
@vdemeester vdemeester deleted the bump-minishift branch November 25, 2018 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vdemeester @xeji @GrahamcOfBorg @c0bw3b