Clean up mod list spacebar handling in GUI #2543
Merged
+26
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you focus the mod list and press space in GUI, some surprising behaviors can occur depending on exactly where you click:
Causes
CKAN has some special code to toggle checkboxes when you press space.
KeyDown
, but we were doing it inKeyPress
, which happens laterChanges
Now the behavior is more consistent and less surprising.
KeyDown
for consistency with the built in behaviorFixes #2534.