Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Fluidsynth music driver support (jmak) #6901

Merged
merged 1 commit into from Nov 1, 2018

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Sep 11, 2018

Heavily based on the jmak's original patch. Only changed to update to @nielsmh's new music system, and a couple of comment tweaks

Build infrastructure might want altering if we want to actually test it/depend on it properly

Closes #6611

@nielsmh
Copy link
Contributor

nielsmh commented Sep 18, 2018

I'll find some time to test and review this one soon. :)

@nielsmh
Copy link
Contributor

nielsmh commented Oct 29, 2018

Cursory testing on Fedora is positive. Configure detects the library automatically (with fluidsynth-devel package installed), and it gets picked as default at runtime. Hasn't had any problems finding music in any of the usual locations, and handles both SMF and MPSMIDI sets.

@nielsmh nielsmh merged commit 0c619b7 into OpenTTD:master Nov 1, 2018
@LordAro LordAro added this to the 1.9.0 milestone Jan 23, 2019
@LordAro LordAro deleted the fluidsynth branch January 7, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants