Skip to content

openshift: 3.10 -> 3.11 #49613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2018
Merged

openshift: 3.10 -> 3.11 #49613

merged 2 commits into from
Nov 12, 2018
+9 −9

Conversation

vdemeester
Copy link
Member

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Bump to latest openshift version. Using go 1.10 instead of 1.9.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 1, 2018
@xeji
Copy link
Contributor

xeji commented Nov 1, 2018

@GrahamcOfBorg build openshift

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openshift

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openshift

Partial log (click to expand)

warning: GOPATH set to GOROOT (/nix/store/gjgfp0k69kbhz4r4p97qr650z4p2cgnb-go-1.10.3/share/go) has no effect
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/f9m9hrmpzshhi830jhh61bq1lb5z4pan-openshift-origin-3.11.0
shrinking /nix/store/f9m9hrmpzshhi830jhh61bq1lb5z4pan-openshift-origin-3.11.0/bin/oc
shrinking /nix/store/f9m9hrmpzshhi830jhh61bq1lb5z4pan-openshift-origin-3.11.0/bin/openshift
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f9m9hrmpzshhi830jhh61bq1lb5z4pan-openshift-origin-3.11.0/bin
patching script interpreter paths in /nix/store/f9m9hrmpzshhi830jhh61bq1lb5z4pan-openshift-origin-3.11.0
checking for references to /build in /nix/store/f9m9hrmpzshhi830jhh61bq1lb5z4pan-openshift-origin-3.11.0...
/nix/store/f9m9hrmpzshhi830jhh61bq1lb5z4pan-openshift-origin-3.11.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openshift

Partial log (click to expand)

warning: GOPATH set to GOROOT (/nix/store/zlav9p2jp91p7vrlv9rbqm1jjmkab5jz-go-1.10.3/share/go) has no effect
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4szszfcn27x2pai7z964pgy7sv5yfyqd-openshift-origin-3.11.0
shrinking /nix/store/4szszfcn27x2pai7z964pgy7sv5yfyqd-openshift-origin-3.11.0/bin/oc
shrinking /nix/store/4szszfcn27x2pai7z964pgy7sv5yfyqd-openshift-origin-3.11.0/bin/openshift
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4szszfcn27x2pai7z964pgy7sv5yfyqd-openshift-origin-3.11.0/bin
patching script interpreter paths in /nix/store/4szszfcn27x2pai7z964pgy7sv5yfyqd-openshift-origin-3.11.0
checking for references to /build in /nix/store/4szszfcn27x2pai7z964pgy7sv5yfyqd-openshift-origin-3.11.0...
/nix/store/4szszfcn27x2pai7z964pgy7sv5yfyqd-openshift-origin-3.11.0

Mic92
Mic92 reviewed Nov 4, 2018
View reviewed changes
pkgs/applications/networking/cluster/openshift/default.nix Outdated
@@ -1,4 +1,4 @@
{ stdenv, lib, fetchFromGitHub, removeReferencesTo, which, go_1_9, go-bindata, makeWrapper, rsync, utillinux
{ stdenv, lib, fetchFromGitHub, removeReferencesTo, which, go_1_10, go-bindata, makeWrapper, rsync, utillinux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would just go works (this would be go 1.11).

@vdemeester
openshift: 3.10 -> 3.11
1ccea55 
Using go 1.10 instead of 1.9

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
openshift: use go instead of go_1_10

Verified

This commit was signed with the committer’s verified signature. The key has expired.
vdemeester Vincent Demeester
GPG key ID: 083CC6FD6EB699A3
Expired
Verified
Learn about vigilant mode
37b50c0 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@Mic92
Copy link
Member

Mic92 commented Nov 12, 2018

@GrahamcOfBorg build openshift

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openshift

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openshift

Partial log (click to expand)

warning: GOPATH set to GOROOT (/nix/store/2jz7z8f6xnx1cv8vr6fmf21y96fg86ri-go-1.11/share/go) has no effect
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v6gm2lbfqm2xd58wf1x5fx10p2c15nd7-openshift-origin-3.11.0
shrinking /nix/store/v6gm2lbfqm2xd58wf1x5fx10p2c15nd7-openshift-origin-3.11.0/bin/oc
shrinking /nix/store/v6gm2lbfqm2xd58wf1x5fx10p2c15nd7-openshift-origin-3.11.0/bin/openshift
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v6gm2lbfqm2xd58wf1x5fx10p2c15nd7-openshift-origin-3.11.0/bin
patching script interpreter paths in /nix/store/v6gm2lbfqm2xd58wf1x5fx10p2c15nd7-openshift-origin-3.11.0
checking for references to /build in /nix/store/v6gm2lbfqm2xd58wf1x5fx10p2c15nd7-openshift-origin-3.11.0...
/nix/store/v6gm2lbfqm2xd58wf1x5fx10p2c15nd7-openshift-origin-3.11.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openshift

Partial log (click to expand)

warning: GOPATH set to GOROOT (/nix/store/g0qnlxjw2qs7rk0aamicy8z3x62pcrx8-go-1.11/share/go) has no effect
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/76cs1pk62pvqcd11w3v4qkygfnyrfs2d-openshift-origin-3.11.0
shrinking /nix/store/76cs1pk62pvqcd11w3v4qkygfnyrfs2d-openshift-origin-3.11.0/bin/openshift
shrinking /nix/store/76cs1pk62pvqcd11w3v4qkygfnyrfs2d-openshift-origin-3.11.0/bin/oc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/76cs1pk62pvqcd11w3v4qkygfnyrfs2d-openshift-origin-3.11.0/bin
patching script interpreter paths in /nix/store/76cs1pk62pvqcd11w3v4qkygfnyrfs2d-openshift-origin-3.11.0
checking for references to /build in /nix/store/76cs1pk62pvqcd11w3v4qkygfnyrfs2d-openshift-origin-3.11.0...
/nix/store/76cs1pk62pvqcd11w3v4qkygfnyrfs2d-openshift-origin-3.11.0

@Mic92 Mic92 merged commit 1499b7c into NixOS:master Nov 12, 2018
@vdemeester vdemeester deleted the bump-openshift branch November 13, 2018 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@rycee rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vdemeester @xeji @GrahamcOfBorg @Mic92 @rycee