Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixops
base: 7450f2a920ea
Choose a base ref
...
head repository: NixOS/nixops
compare: 6da4190e9178
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Sep 12, 2018

  1. Make sure that the machine is UP before trying to destroy it in GCP 

    This can cause problems since we issue API call without actually checking
if the node is up or not. One easy way to see the manifestation of this
bug is to create a deployment with a machine that has underscore in
it's  name (It's not supported in GCP). And without even deploying,
try to destroy it. The expected behavior is nothing! Since the
machine is down. However, an exception is raised because nixops tries
to call the API to get the node.
    @benhamad
    benhamad committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    a796552 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2018

  1. Merge pull request #1002 from Chakerbh/gcp_destroy 

    Make sure that the machine is UP before trying to destroy it in GCP
    @AmineChikhaoui
    AmineChikhaoui committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    6da4190 View commit details
    Browse the repository at this point in the history