Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireshark: include headers in wireshark.dev, to support building wireshark plugins #49242

Merged
merged 1 commit into from Oct 27, 2018
Merged

wireshark: include headers in wireshark.dev, to support building wireshark plugins #49242

merged 1 commit into from Oct 27, 2018

Conversation

cleverca22
Copy link
Contributor

Motivation for this change

this allows building wireshark plugins via nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@cleverca22
Copy link
Contributor Author

@GrahamcOfBorg build wireshark

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wireshark

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zn6kk1h6q68m9qm4r26dspj1zrflkgm5-wireshark-qt-2.6.4/lib  /nix/store/zn6kk1h6q68m9qm4r26dspj1zrflkgm5-wireshark-qt-2.6.4/bin
patching script interpreter paths in /nix/store/zn6kk1h6q68m9qm4r26dspj1zrflkgm5-wireshark-qt-2.6.4
checking for references to /build in /nix/store/zn6kk1h6q68m9qm4r26dspj1zrflkgm5-wireshark-qt-2.6.4...
shrinking RPATHs of ELF executables and libraries in /nix/store/qq415nm6d1c4iq6xgh3ynbsmhhdnlizn-wireshark-qt-2.6.4-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qq415nm6d1c4iq6xgh3ynbsmhhdnlizn-wireshark-qt-2.6.4-dev/lib
patching script interpreter paths in /nix/store/qq415nm6d1c4iq6xgh3ynbsmhhdnlizn-wireshark-qt-2.6.4-dev
checking for references to /build in /nix/store/qq415nm6d1c4iq6xgh3ynbsmhhdnlizn-wireshark-qt-2.6.4-dev...
postPatchMkspecs

@cleverca22 cleverca22 merged commit 18d8870 into NixOS:master Oct 27, 2018
@cleverca22 cleverca22 deleted the wireshark-add-headers branch October 27, 2018 11:40
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wireshark

Partial log (click to expand)

these derivations will be built:
  /nix/store/msfk5zfgjwmi8gmx0psyig000dh7nswq-qtdeclarative-5.9.3.drv
  /nix/store/6fvf8dx990j51n361a2r15nsk1zsvmnl-qtmultimedia-5.9.3.drv
  /nix/store/ijc8id7ag2gwwkxndg0076j1dzr567iv-wireshark-qt-2.6.4.drv
waiting for locks or build slots...
/nix/store/sr5p0pyrk93xh7w27npqni9w0r9clp7x-wireshark-qt-2.6.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wireshark

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sr5p0pyrk93xh7w27npqni9w0r9clp7x-wireshark-qt-2.6.4/lib  /nix/store/sr5p0pyrk93xh7w27npqni9w0r9clp7x-wireshark-qt-2.6.4/bin
patching script interpreter paths in /nix/store/sr5p0pyrk93xh7w27npqni9w0r9clp7x-wireshark-qt-2.6.4
checking for references to /build in /nix/store/sr5p0pyrk93xh7w27npqni9w0r9clp7x-wireshark-qt-2.6.4...
shrinking RPATHs of ELF executables and libraries in /nix/store/vv34a68i4zpcmijv4v8y20337kky78nd-wireshark-qt-2.6.4-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vv34a68i4zpcmijv4v8y20337kky78nd-wireshark-qt-2.6.4-dev/lib
patching script interpreter paths in /nix/store/vv34a68i4zpcmijv4v8y20337kky78nd-wireshark-qt-2.6.4-dev
checking for references to /build in /nix/store/vv34a68i4zpcmijv4v8y20337kky78nd-wireshark-qt-2.6.4-dev...
postPatchMkspecs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wireshark

Partial log (click to expand)

/nix/store/zn6kk1h6q68m9qm4r26dspj1zrflkgm5-wireshark-qt-2.6.4

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: wireshark

Partial log (click to expand)

/nix/store/6nks6k04bbskz4ihkk2499sdicvcz3gc-qtbase-5.9.3-dev/bin/qmake -install qinstall /private/tmp/nix-build-qtdeclarative-5.9.3.drv-0/qtdeclarative-opensource-src-5.9.3/src/qml/compiler/qv4codegen_p.h /nix/store/ssafmc3klz529fxlikywns337biijhvi-qtdeclarative-5.9.3-dev/include/QtQml/5.9.3/QtQml/private/qv4codegen_p.h
/nix/store/6nks6k04bbskz4ihkk2499sdicvcz3gc-qtbase-5.9.3-dev/bin/qmake -install qinstall /private/tmp/nix-build-qtdeclarative-5.9.3.drv-0/qtdeclarative-opensource-src-5.9.3/src/qml/compiler/qv4compilationunitmapper_p.h /nix/store/ssafmc3klz529fxlikywns337biijhvi-qtdeclarative-5.9.3-dev/include/QtQml/5.9.3/QtQml/private/qv4compilationunitmapper_p.h
/nix/store/6nks6k04bbskz4ihkk2499sdicvcz3gc-qtbase-5.9.3-dev/bin/qmake -install qinstall /private/tmp/nix-build-qtdeclarative-5.9.3.drv-0/qtdeclarative-opensource-src-5.9.3/src/qml/compiler/qv4compileddata_p.h /nix/store/ssafmc3klz529fxlikywns337biijhvi-qtdeclarative-5.9.3-dev/include/QtQml/5.9.3/QtQml/private/qv4compileddata_p.h
/nix/store/6nks6k04bbskz4ihkk2499sdicvcz3gc-qtbase-5.9.3-dev/bin/qmake -install qinstall /private/tmp/nix-build-qtdeclarative-5.9.3.drv-0/qtdeclarative-opensource-src-5.9.3/src/qml/compiler/qv4compiler_p.h /nix/store/ssafmc3klz529fxlikywns337biijhvi-qtdeclarative-5.9.3-dev/include/QtQml/5.9.3/QtQml/private/qv4compiler_p.h
/nix/store/6nks6k04bbskz4ihkk2499sdicvcz3gc-qtbase-5.9.3-dev/bin/qmake -install qinstall /private/tmp/nix-build-qtdeclarative-5.9.3.drv-0/qtdeclarative-opensource-src-5.9.3/src/qml/compiler/qv4instr_moth_p.h /nix/store/ssafmc3klz529fxlikywns337biijhvi-qtdeclarative-5.9.3-dev/include/QtQml/5.9.3/QtQml/private/qv4instr_moth_p.h
/nix/store/6nks6k04bbskz4ihkk2499sdicvcz3gc-qtbase-5.9.3-dev/bin/qmake -install qinstall /private/tmp/nix-build-qtdeclarative-5.9.3.drv-0/qtdeclarative-opensource-src-5.9.3/src/qml/compiler/qv4isel_moth_p.h /nix/store/ssafmc3klz529fxlikywns337biijhvi-qtdeclarative-5.9.3-dev/include/QtQml/5.9.3/QtQml/private/qv4isel_moth_p.h
building of '/nix/store/x33q4xyil2449h1xraf3fb6dj6h32id9-qtdeclarative-5.9.3.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/91k23bkbb5lhzb68r7cr03rgwdv43s2b-qtmultimedia-5.9.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cy3d2hw5fvldj5zw8n7l7vyfsc1zq4a5-wireshark-qt-2.6.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/cy3d2hw5fvldj5zw8n7l7vyfsc1zq4a5-wireshark-qt-2.6.4.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: wireshark

Partial log (click to expand)

/nix/store/2fcp0qavk5dhvdsf5vaqwzfhw39f5rbs-wireshark-qt-2.6.4/Applications/Wireshark.app/Contents/Frameworks/libwscodecs.2.0.0.dylib: fixing dylib
/nix/store/2fcp0qavk5dhvdsf5vaqwzfhw39f5rbs-wireshark-qt-2.6.4/Applications/Wireshark.app/Contents/Frameworks/libwsutil.9.0.0.dylib: fixing dylib
/nix/store/2fcp0qavk5dhvdsf5vaqwzfhw39f5rbs-wireshark-qt-2.6.4/lib/libwireshark.11.1.4.dylib: fixing dylib
/nix/store/2fcp0qavk5dhvdsf5vaqwzfhw39f5rbs-wireshark-qt-2.6.4/lib/libwiretap.8.0.4.dylib: fixing dylib
/nix/store/2fcp0qavk5dhvdsf5vaqwzfhw39f5rbs-wireshark-qt-2.6.4/lib/libwscodecs.2.0.0.dylib: fixing dylib
/nix/store/2fcp0qavk5dhvdsf5vaqwzfhw39f5rbs-wireshark-qt-2.6.4/lib/libwsutil.9.0.0.dylib: fixing dylib
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/5dkpaal34svddsdmrrbnnhklsibl1vjz-wireshark-qt-2.6.4-dev/lib
patching script interpreter paths in /nix/store/5dkpaal34svddsdmrrbnnhklsibl1vjz-wireshark-qt-2.6.4-dev
postPatchMkspecs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cleverca22 @GrahamcOfBorg @disassembler