Show mod info for change set, recs/sugs, and providers #2556
+127
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
|
This is a great idea, but I find that the mod info pane is oddly higher than the mod list. Could you add a spacer to move the mod tabs down a bit. Perhaps throw a CKAN logo in it? |
|
Uh oh, UI design? I was afraid that might happen... 😜 |
|
What if we put the name/description pane above the tabstrip? Then it can serve as a sort of label for all the tabs, as well as displacing them downwards to deal with the visual offset situation:
|
HebaruSan
force-pushed
the
feature/omni-modinfo
branch
from
406844c to
522edbf
Compare
|
Pushed a new commit with the above change. |
|
Hmm, that's better, but still looks a little weird when you stretch out the window to see more of the modlist on a 4K monitor. I'll see if it grows on me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
GUI has several places where mods are listed but all the user can access is their name and abstract.
If you want to see the long description, license, home page, relationships, etc., you have to cancel whatever you're doing and then look up the mods separately on the main mod list.
Changes
Now the mod info pane is available in these lists if you click a row. This allows the user to get complete info about any mod about which they're being asked to make decisions. The mod info pane will disappear if you clear the list's selection.
Main mod list:
Provides:
Change set:
Recommendations:
To accomplish this, the structure of the main form is rearranged so the vertical splitter now contains the main tab control and the mod info:
Pre:
Post:
Then when the selection changes in any of those lists, we get the
CkanModulefor it, create aGUIMod, and pass it to the mod info pane.Fixes #1868.