Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] nextcloud-client: 2.3.2 -> 2.5.0-rc1 #49169

Closed
wants to merge 1 commit into from
Closed

[WIP] nextcloud-client: 2.3.2 -> 2.5.0-rc1 #49169

wants to merge 1 commit into from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Oct 26, 2018

Motivation for this change

This updates the nextcloud-client from 2.3.2 (which was the owncloud-client with a nextcloud theme) to 2.5.0 (which is now an independent fork of the owncloud-client).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@caugner
Copy link
Contributor Author

caugner commented Oct 26, 2018

I'm trying to build it locally, but it's taking a lot of time, whereas the Drone CI builds of nextcloud/desktop are significantly fastler).

Maybe we're compiling more than we need to?

@caugner caugner changed the title WIP - nextcloud-client: 2.3.2 -> 2.5.0-rc1 [WIP] nextcloud-client: 2.3.2 -> 2.5.0-rc1 Oct 26, 2018
@eqyiel
Copy link
Contributor

eqyiel commented Oct 28, 2018

I successfully packaged the beta at some point, you may be able to copy some stuff from here: https://github.com/eqyiel/dotfiles/blob/dff548627e65fd06a318de4d38f892768eaec1b0/nix/.config/nixpkgs/packages/nextcloud-client/default.nix

While doing so I encountered runtime errors (segmentation fault) unless I built the package with OpenSSL 1.1, which meant building Qt5 with OpenSSL 1.1 due to propagated inputs: https://github.com/eqyiel/dotfiles/blob/dff548627e65fd06a318de4d38f892768eaec1b0/nix/.config/nixpkgs/packages/all-packages.nix#L96-L112

@Ma27
Copy link
Member

Ma27 commented Nov 22, 2018

@caugner @eqyiel would you mind testing my patch (#50463)? It seems to properly migrate the patch and you don't have to recompile anymore when enabling gnome-keyring support :)

@caugner
Copy link
Contributor Author

caugner commented Nov 22, 2018

@Ma27 Thanks, I'm closing my PR in favor of yours (#50463) and will try to test your patch in the next couple of days.

@caugner caugner closed this Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@caugner @eqyiel @Ma27 @roberth @GrahamcOfBorg