Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eternal-terminal: enable darwin build. #49167

Merged
merged 1 commit into from Oct 26, 2018
Merged

eternal-terminal: enable darwin build. #49167

merged 1 commit into from Oct 26, 2018

Conversation

qolii
Copy link
Contributor

@qolii qolii commented Oct 26, 2018

Motivation for this change

Turns out, this builds and works perfectly on the Mac. So, this change enables it there.

Tested by connecting from Mac to NixOS machine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Oct 26, 2018
@dezgeg dezgeg merged commit 1456273 into NixOS:master Oct 26, 2018
@qolii
Copy link
Contributor Author

qolii commented Oct 26, 2018

Aaaaand we have just broken the record for fastest merge in history. Thanks!!

@qolii qolii deleted the eternal-terminal__darwin branch October 26, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qolii @dezgeg @GrahamcOfBorg