Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] mosquitto: 1.4.15 -> 1.5.3 #49186

Merged
merged 1 commit into from Oct 27, 2018
Merged

[18.09] mosquitto: 1.4.15 -> 1.5.3 #49186

merged 1 commit into from Oct 27, 2018

Conversation

andir
Copy link
Member

@andir andir commented Oct 26, 2018

Motivation for this change

This is a backport of changes from master that fix several security issues that did arise in the mosquitto MQTT server.

I read through the changelog and it doesn't seem to introduce any breaking changes. There are many bugfixes. One fix on timeout behavior could be seen as breakage but AFAIK that was on an edge case and can probably be let through.

cc release managers for 18.09 @samueldr @vcunat

Things done

[X] Recompiled using sandboxing on NixOS

@peterhoeg @andir
mosquitto: 1.4.15 -> 1.5.3
3581f5b 
This backport to 18.09 fixes a serious of security related issues in
mosquitto when run as a server.

Use cmake on all platforms instead of only macos.

(cherry picked from commit a45fa35)
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mosquitto

Partial log (click to expand)

shrinking /nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3/bin/mosquitto_pub
shrinking /nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3/lib/libmosquittopp.so.1.5.3
shrinking /nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3/lib/libmosquitto.so.1.5.3
gzipping man pages under /nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3/lib  /nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3/bin  /nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3/sbin
patching script interpreter paths in /nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3
checking for references to /build in /nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3...
moving /nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3/sbin/* to /nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3/bin
/nix/store/md0yy79xhvsjj9grjn5gvrsh2fwd7qv6-mosquitto-1.5.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: mosquitto

Partial log (click to expand)

-- Installing: /nix/store/81wiikh6qx03000mjg86sbqnidpkrcf5-mosquitto-1.5.3/share/man/man7/mosquitto-tls.7
-- Installing: /nix/store/81wiikh6qx03000mjg86sbqnidpkrcf5-mosquitto-1.5.3/share/man/man7/mqtt.7
-- Installing: /nix/store/81wiikh6qx03000mjg86sbqnidpkrcf5-mosquitto-1.5.3/share/man/man8/mosquitto.8
post-installation fixup
gzipping man pages under /nix/store/81wiikh6qx03000mjg86sbqnidpkrcf5-mosquitto-1.5.3/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/81wiikh6qx03000mjg86sbqnidpkrcf5-mosquitto-1.5.3/lib  /nix/store/81wiikh6qx03000mjg86sbqnidpkrcf5-mosquitto-1.5.3/bin  /nix/store/81wiikh6qx03000mjg86sbqnidpkrcf5-mosquitto-1.5.3/sbin
patching script interpreter paths in /nix/store/81wiikh6qx03000mjg86sbqnidpkrcf5-mosquitto-1.5.3
moving /nix/store/81wiikh6qx03000mjg86sbqnidpkrcf5-mosquitto-1.5.3/sbin/* to /nix/store/81wiikh6qx03000mjg86sbqnidpkrcf5-mosquitto-1.5.3/bin
/nix/store/81wiikh6qx03000mjg86sbqnidpkrcf5-mosquitto-1.5.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mosquitto

Partial log (click to expand)

shrinking /nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3/bin/mosquitto_sub
shrinking /nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3/bin/mosquitto_passwd
shrinking /nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3/bin/mosquitto_pub
gzipping man pages under /nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3/lib  /nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3/bin  /nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3/sbin
patching script interpreter paths in /nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3
checking for references to /build in /nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3...
moving /nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3/sbin/* to /nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3/bin
/nix/store/y0lfsc5912rg7a2lgjz9vsrljnx3nx8i-mosquitto-1.5.3

@andir andir merged commit 73a4857 into NixOS:release-18.09 Oct 27, 2018
@andir andir deleted the 18.09/mosquitto branch October 27, 2018 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @GrahamcOfBorg @peterhoeg