virtualgl-lib: fix broken startup script #49185

markuskowa · 2018-10-26T19:55:45Z

Motivation for this change

Replace /bin/sh for bash in vglrun.
The script uses exec, which fails with /bin/sh

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

Mic92 · 2018-10-28T23:30:37Z

pkgs/tools/X11/virtualgl/lib.nix

+  postPatch = ''
+    # script calls exec, which fails with plain sh
+    substituteInPlace ./server/vglrun.in \
+      --replace '#!/bin/sh' '#!${stdenv.shell}'


Can this be also fixed by the patchShebangs script?

That won't give me a bash but the path to a sh (I tried).

Also reported here: VirtualGL/virtualgl#87

Replace /bin/sh with bash in vglrun. 'exec' fails with /bin/sh

markuskowa · 2018-10-29T08:07:09Z

This fix also needs a backport to 18.09

xeji · 2018-10-30T15:06:30Z

@GrahamcOfBorg build virtualglLib

GrahamcOfBorg · 2018-10-30T15:06:48Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: virtualglLib

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-30T15:07:13Z

Success on aarch64-linux (full log)

Attempted: virtualglLib

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zkhlykr5y22h3qh0fv7bl8xj4pzz3nl2-virtualgl-lib-2.5.2/lib  /nix/store/zkhlykr5y22h3qh0fv7bl8xj4pzz3nl2-virtualgl-lib-2.5.2/bin
patching script interpreter paths in /nix/store/zkhlykr5y22h3qh0fv7bl8xj4pzz3nl2-virtualgl-lib-2.5.2
/nix/store/zkhlykr5y22h3qh0fv7bl8xj4pzz3nl2-virtualgl-lib-2.5.2/bin/vglconnect: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/zkhlykr5y22h3qh0fv7bl8xj4pzz3nl2-virtualgl-lib-2.5.2/bin/vglrun: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/zkhlykr5y22h3qh0fv7bl8xj4pzz3nl2-virtualgl-lib-2.5.2/bin/vglserver_config: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/zkhlykr5y22h3qh0fv7bl8xj4pzz3nl2-virtualgl-lib-2.5.2/bin/vgllogin: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/zkhlykr5y22h3qh0fv7bl8xj4pzz3nl2-virtualgl-lib-2.5.2/bin/vglgenkey: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/zkhlykr5y22h3qh0fv7bl8xj4pzz3nl2-virtualgl-lib-2.5.2...
/nix/store/zkhlykr5y22h3qh0fv7bl8xj4pzz3nl2-virtualgl-lib-2.5.2

GrahamcOfBorg · 2018-10-30T15:10:19Z

Success on x86_64-linux (full log)

Attempted: virtualglLib

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i4jsnzwdsqk0zzbh9clv0kw01xnzjniv-virtualgl-lib-2.5.2/lib  /nix/store/i4jsnzwdsqk0zzbh9clv0kw01xnzjniv-virtualgl-lib-2.5.2/bin
patching script interpreter paths in /nix/store/i4jsnzwdsqk0zzbh9clv0kw01xnzjniv-virtualgl-lib-2.5.2
/nix/store/i4jsnzwdsqk0zzbh9clv0kw01xnzjniv-virtualgl-lib-2.5.2/bin/vglserver_config: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/i4jsnzwdsqk0zzbh9clv0kw01xnzjniv-virtualgl-lib-2.5.2/bin/vglgenkey: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/i4jsnzwdsqk0zzbh9clv0kw01xnzjniv-virtualgl-lib-2.5.2/bin/vglrun: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/i4jsnzwdsqk0zzbh9clv0kw01xnzjniv-virtualgl-lib-2.5.2/bin/vgllogin: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/i4jsnzwdsqk0zzbh9clv0kw01xnzjniv-virtualgl-lib-2.5.2/bin/vglconnect: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/i4jsnzwdsqk0zzbh9clv0kw01xnzjniv-virtualgl-lib-2.5.2...
/nix/store/i4jsnzwdsqk0zzbh9clv0kw01xnzjniv-virtualgl-lib-2.5.2

xeji · 2018-10-30T15:10:30Z

@GrahamcOfBorg build virtualgl bumblebee

GrahamcOfBorg · 2018-10-30T15:10:44Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: virtualgl, bumblebee

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-30T15:10:50Z

Success on aarch64-linux (full log)

Attempted: virtualgl

The following builds were skipped because they don't evaluate on aarch64-linux: bumblebee

Partial log (click to expand)


b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


these derivations will be built:
  /nix/store/k886nw0bqxxs21n3l2fhlgg0nfv9cfwp-virtualgl-2.5.2.drv
building '/nix/store/k886nw0bqxxs21n3l2fhlgg0nfv9cfwp-virtualgl-2.5.2.drv'...
/nix/store/h5d9y3g8kamgsxawrg9rwml6zblx8zhz-virtualgl-2.5.2

GrahamcOfBorg · 2018-10-30T15:14:53Z

Success on x86_64-linux (full log)

Attempted: virtualgl

The following builds were skipped because they don't evaluate on x86_64-linux: bumblebee

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/i4qxmp8zagklbrwa3g9c5qc9vxr1j092-virtualgl-lib-2.5.2/lib  /nix/store/i4qxmp8zagklbrwa3g9c5qc9vxr1j092-virtualgl-lib-2.5.2/bin
patching script interpreter paths in /nix/store/i4qxmp8zagklbrwa3g9c5qc9vxr1j092-virtualgl-lib-2.5.2
/nix/store/i4qxmp8zagklbrwa3g9c5qc9vxr1j092-virtualgl-lib-2.5.2/bin/vglserver_config: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
/nix/store/i4qxmp8zagklbrwa3g9c5qc9vxr1j092-virtualgl-lib-2.5.2/bin/vglgenkey: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
/nix/store/i4qxmp8zagklbrwa3g9c5qc9vxr1j092-virtualgl-lib-2.5.2/bin/vglrun: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/bash"
/nix/store/i4qxmp8zagklbrwa3g9c5qc9vxr1j092-virtualgl-lib-2.5.2/bin/vgllogin: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
/nix/store/i4qxmp8zagklbrwa3g9c5qc9vxr1j092-virtualgl-lib-2.5.2/bin/vglconnect: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/i4qxmp8zagklbrwa3g9c5qc9vxr1j092-virtualgl-lib-2.5.2...
building '/nix/store/2m3d17mimkrfvdmjyamvbbz5wh64c3lk-virtualgl-2.5.2.drv'...
/nix/store/n37jmykx5dfds9sjaynqx7n3c5b98lq3-virtualgl-2.5.2

Replace /bin/sh with bash in vglrun. 'exec' fails with /bin/sh (cherry picked from commit efd3f8b)

xeji · 2018-10-30T15:20:32Z

backported in c341f56.

This reverts commit efd3f8b.

This reverts commit c341f56. See #49611.

virtualgl: revert PR #49185

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Oct 26, 2018

Mic92 reviewed Oct 28, 2018

View reviewed changes

virtualgl-lib: fix broken startup script

9c3c59e

Replace /bin/sh with bash in vglrun. 'exec' fails with /bin/sh

markuskowa force-pushed the fix-virtualgl branch from 5cb3ccf to 9c3c59e Compare October 29, 2018 08:05

xeji merged commit efd3f8b into NixOS:master Oct 30, 2018

xeji pushed a commit that referenced this pull request Oct 30, 2018

virtualgl-lib: fix broken startup script (#49185)

c341f56

Replace /bin/sh with bash in vglrun. 'exec' fails with /bin/sh (cherry picked from commit efd3f8b)

markuskowa mentioned this pull request Nov 1, 2018

virtualgl: revert PR #49185 #49611

Merged

9 tasks

markuskowa added a commit to markuskowa/nixpkgs that referenced this pull request Nov 1, 2018

Revert "virtualgl-lib: fix broken startup script (NixOS#49185)"

ddd761a

This reverts commit efd3f8b.

xeji added a commit that referenced this pull request Nov 1, 2018

Revert "virtualgl-lib: fix broken startup script (#49185)"

394ca68

This reverts commit c341f56. See #49611.

xeji added a commit that referenced this pull request Nov 1, 2018

Merge pull request #49611 from markuskowa/rev-virtualgl

a1d4a77

virtualgl: revert PR #49185

markuskowa deleted the fix-virtualgl branch November 7, 2018 19:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

virtualgl-lib: fix broken startup script #49185

virtualgl-lib: fix broken startup script #49185

markuskowa commented Oct 26, 2018

Mic92 Oct 28, 2018

markuskowa Oct 28, 2018

Mic92 Oct 29, 2018

markuskowa commented Oct 29, 2018

xeji commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

xeji commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

xeji commented Oct 30, 2018

virtualgl-lib: fix broken startup script #49185

virtualgl-lib: fix broken startup script #49185

Conversation

markuskowa commented Oct 26, 2018

Motivation for this change

Things done

Mic92 Oct 28, 2018

Choose a reason for hiding this comment

markuskowa Oct 28, 2018

Choose a reason for hiding this comment

Mic92 Oct 29, 2018

Choose a reason for hiding this comment

markuskowa commented Oct 29, 2018

xeji commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

xeji commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

GrahamcOfBorg commented Oct 30, 2018

xeji commented Oct 30, 2018