Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loc: enable darwin build #49224

Merged
merged 1 commit into from Oct 27, 2018
Merged

loc: enable darwin build #49224

merged 1 commit into from Oct 27, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Oct 27, 2018

It works fine there and probably other unix platforms.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
loc: enable darwin build
561fb30 
It works fine there and probably other unix platforms.
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: loc

Partial log (click to expand)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/47iclsb91rvmvcc3d5q2y8rik6i6wcsb-loc-0.4.1/bin
patching script interpreter paths in /nix/store/47iclsb91rvmvcc3d5q2y8rik6i6wcsb-loc-0.4.1
/nix/store/47iclsb91rvmvcc3d5q2y8rik6i6wcsb-loc-0.4.1

@dywedir dywedir merged commit a136c98 into NixOS:master Oct 27, 2018
@LnL7 LnL7 deleted the darwin-loc branch October 27, 2018 09:34
@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: loc

Partial log (click to expand)

Scanning dependencies of target LLVMARMAsmParser
make[3]: Leaving directory '/build/rustc-1.30.0-src/build/x86_64-unknown-linux-gnu/llvm/build'
make[3]: Entering directory '/build/rustc-1.30.0-src/build/x86_64-unknown-linux-gnu/llvm/build'
[ 62%] Building CXX object lib/Target/ARM/AsmParser/CMakeFiles/LLVMARMAsmParser.dir/ARMAsmParser.cpp.o
[ 62%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMCodeGenPrepare.cpp.o
[ 62%] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FloatingPoint.cpp.o
building of '/nix/store/j1yzzw5jg9dpxlrcp5mj8awfgh755byb-rustc-1.30.0.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/amvxhnkmn7szrbgp5k6zrd9nrms8i7cj-cargo-1.30.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n84pk2ad4llpfw2d6wndgv2v0419nlr7-loc-0.4.1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/n84pk2ad4llpfw2d6wndgv2v0419nlr7-loc-0.4.1.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: loc

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xlrwh901xwf6n2isa3bpdlwm1ha6pjaz-loc-0.4.1
shrinking /nix/store/xlrwh901xwf6n2isa3bpdlwm1ha6pjaz-loc-0.4.1/bin/loc
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xlrwh901xwf6n2isa3bpdlwm1ha6pjaz-loc-0.4.1/bin
patching script interpreter paths in /nix/store/xlrwh901xwf6n2isa3bpdlwm1ha6pjaz-loc-0.4.1
checking for references to /build in /nix/store/xlrwh901xwf6n2isa3bpdlwm1ha6pjaz-loc-0.4.1...
/nix/store/xlrwh901xwf6n2isa3bpdlwm1ha6pjaz-loc-0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @dywedir