Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.aioprocessing: init at 1.0.1 #49170

Merged
merged 1 commit into from Oct 29, 2018
Merged

pythonPackages.aioprocessing: init at 1.0.1 #49170

merged 1 commit into from Oct 29, 2018

Conversation

uskudnik
Copy link
Contributor

Motivation for this change

Add aioprocessing module

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@uskudnik uskudnik requested a review from FRidh as a code owner October 26, 2018 17:24
@symphorien
Copy link
Member

did you try setting doCheck = true; ?

@uskudnik uskudnik force-pushed the add-aioprocessing branch 2 times, most recently from 833e450 to f1b2825 Compare October 26, 2018 19:22
@uskudnik
Copy link
Contributor Author

@symphorien I did, tests are excluded from the package so no tests are run:

Ran 0 tests in 0.000s

OK

dotlambda
dotlambda reviewed Oct 27, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set doCheck = false and add a comment with the reason.

Btw: dano/aioprocessing#25

pkgs/development/python-modules/aioprocessing/default.nix Outdated
meta = {
description = "A library that integrates the multiprocessing module with asyncio";
homepage = https://github.com/dano/aioprocessing;
license = with lib.licenses; [ bsd2 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = with lib.licenses; [ bsd2 ];
license = lib.licenses.bsd2;

@uskudnik
Copy link
Contributor Author

@dotlambda Is there a reason for adding doCheck = false? Per manual entry it seems to be by default false anyway?

Anyway, included it anyway to make it explicit.

@dotlambda
Copy link
Member

For buildPython*, doCheck = true is the default.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.aioprocessing python3.pkgs.aioprocessing

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.aioprocessing

The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.aioprocessing

Partial log (click to expand)

Installing collected packages: aioprocessing
Successfully installed aioprocessing-1.0.1
/build/aioprocessing-1.0.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w6r8s9wx4mdjiqsr5qh8kdzb5m3y1m2f-python3.6-aioprocessing-1.0.1
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w6r8s9wx4mdjiqsr5qh8kdzb5m3y1m2f-python3.6-aioprocessing-1.0.1/lib
patching script interpreter paths in /nix/store/w6r8s9wx4mdjiqsr5qh8kdzb5m3y1m2f-python3.6-aioprocessing-1.0.1
checking for references to /build in /nix/store/w6r8s9wx4mdjiqsr5qh8kdzb5m3y1m2f-python3.6-aioprocessing-1.0.1...
/nix/store/w6r8s9wx4mdjiqsr5qh8kdzb5m3y1m2f-python3.6-aioprocessing-1.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3.pkgs.aioprocessing

The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.aioprocessing

Partial log (click to expand)

/private/tmp/nix-build-python3.6-aioprocessing-1.0.1.drv-0/aioprocessing-1.0.1/dist /private/tmp/nix-build-python3.6-aioprocessing-1.0.1.drv-0/aioprocessing-1.0.1
Processing ./aioprocessing-1.0.1-py3-none-any.whl
Installing collected packages: aioprocessing
Successfully installed aioprocessing-1.0.1
/private/tmp/nix-build-python3.6-aioprocessing-1.0.1.drv-0/aioprocessing-1.0.1
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/3j15r1zgyzaw41p2axx8hd9vjw02j1ay-python3.6-aioprocessing-1.0.1/lib
patching script interpreter paths in /nix/store/3j15r1zgyzaw41p2axx8hd9vjw02j1ay-python3.6-aioprocessing-1.0.1
/nix/store/3j15r1zgyzaw41p2axx8hd9vjw02j1ay-python3.6-aioprocessing-1.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.aioprocessing

The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.aioprocessing

Partial log (click to expand)

Installing collected packages: aioprocessing
Successfully installed aioprocessing-1.0.1
/build/aioprocessing-1.0.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gnziy4bn79a7ff3aifwbk81layw3pj09-python3.6-aioprocessing-1.0.1
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gnziy4bn79a7ff3aifwbk81layw3pj09-python3.6-aioprocessing-1.0.1/lib
patching script interpreter paths in /nix/store/gnziy4bn79a7ff3aifwbk81layw3pj09-python3.6-aioprocessing-1.0.1
checking for references to /build in /nix/store/gnziy4bn79a7ff3aifwbk81layw3pj09-python3.6-aioprocessing-1.0.1...
/nix/store/gnziy4bn79a7ff3aifwbk81layw3pj09-python3.6-aioprocessing-1.0.1

@dotlambda dotlambda merged commit 5adfcb9 into NixOS:master Oct 29, 2018
@uskudnik
Copy link
Contributor Author

@dotlambda Ahhh, thanks, didn't check the buildPythonPackage for that.

@uskudnik uskudnik deleted the add-aioprocessing branch July 30, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uskudnik @symphorien @dotlambda @GrahamcOfBorg