Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gusb: 0.2.11 → 0.3.0 #49183

Merged
merged 2 commits into from Oct 26, 2018
Merged

gusb: 0.2.11 → 0.3.0 #49183

merged 2 commits into from Oct 26, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 26, 2018 •
edited

Motivation for this change

Size impact: 6% overall increase (115 MB → 122 MB due to 7 MB hwinfo). But we also split the outputs now, reducing the size of out to 51 MB.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gusb, hwdata

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gusb, hwdata

Partial log (click to expand)

--- stdout ---
/gusb/context:
--- stderr ---
**
libgusb:ERROR:../gusb/gusb-self-test.c:97:gusb_context_func: assertion failed (array->len > 0): (0 > 0)
-------

Full log written to /build/libgusb-0.3.0/build/meson-logs/testlog.txt
builder for '/nix/store/693c227k4rc3pnc9b6wzq3296w1l4fk5-gusb-0.3.0.drv' failed with exit code 1
error: build of '/nix/store/693c227k4rc3pnc9b6wzq3296w1l4fk5-gusb-0.3.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: gusb, hwdata

Partial log (click to expand)

--- stdout ---
/gusb/context:
--- stderr ---
**
libgusb:ERROR:../gusb/gusb-self-test.c:97:gusb_context_func: assertion failed (array->len > 0): (0 > 0)
-------

Full log written to /build/libgusb-0.3.0/build/meson-logs/testlog.txt
builder for '/nix/store/1iizbpll1dj3vlvfq0q94qqm5b44dvks-gusb-0.3.0.drv' failed with exit code 1
error: build of '/nix/store/1iizbpll1dj3vlvfq0q94qqm5b44dvks-gusb-0.3.0.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gusb, hwdata

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gusb, hwdata

Partial log (click to expand)

checking for references to /build in /nix/store/dvxrsnhv3zmsws0z3xlw9vjg1g5q9hg9-gusb-0.3.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/a6g3i94gkkwpc6ypmkjwgp5ah5hkhv57-gusb-0.3.0-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a6g3i94gkkwpc6ypmkjwgp5ah5hkhv57-gusb-0.3.0-dev/lib
patching script interpreter paths in /nix/store/a6g3i94gkkwpc6ypmkjwgp5ah5hkhv57-gusb-0.3.0-dev
checking for references to /build in /nix/store/a6g3i94gkkwpc6ypmkjwgp5ah5hkhv57-gusb-0.3.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/2pb5lfni59pm9x65kvpxdphznfbcrpxx-gusb-0.3.0-devdoc
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2pb5lfni59pm9x65kvpxdphznfbcrpxx-gusb-0.3.0-devdoc
checking for references to /build in /nix/store/2pb5lfni59pm9x65kvpxdphznfbcrpxx-gusb-0.3.0-devdoc...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gusb, hwdata

Partial log (click to expand)

checking for references to /build in /nix/store/67sj8iyk3f8zcvrn24n5fib0cb8s8f4l-gusb-0.3.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/b4k186x9sfc45fjzjk0wplza7s5qzln4-gusb-0.3.0-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b4k186x9sfc45fjzjk0wplza7s5qzln4-gusb-0.3.0-dev/lib
patching script interpreter paths in /nix/store/b4k186x9sfc45fjzjk0wplza7s5qzln4-gusb-0.3.0-dev
checking for references to /build in /nix/store/b4k186x9sfc45fjzjk0wplza7s5qzln4-gusb-0.3.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/k74z4s427vi7wkbxwxb997gbm3pmv9k8-gusb-0.3.0-devdoc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/k74z4s427vi7wkbxwxb997gbm3pmv9k8-gusb-0.3.0-devdoc
checking for references to /build in /nix/store/k74z4s427vi7wkbxwxb997gbm3pmv9k8-gusb-0.3.0-devdoc...

@jtojnar jtojnar merged commit df9290f into NixOS:master Oct 26, 2018
@jtojnar jtojnar deleted the gusb branch October 26, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg