Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-slim-10_x: 10.12.0 -> 11.0.0 #49207

Closed
wants to merge 1 commit into from
Closed

nodejs-slim-10_x: 10.12.0 -> 11.0.0 #49207

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/nodejs-slim/versions.

meta.description for nodejs-slim-10_x is: '"Event-driven I/O framework for the V8 JavaScript engine"'.

Checks done (click to expand)
Outpath report (click to expand)

Outpath difference report
12 total rebuild paths

3 package rebuilds

3 x86_64-linux rebuilds
3 i686-linux rebuilds
3 x86_64-darwin rebuilds
3 aarch64-linux rebuilds

First ten rebuilds by attrpath
heroku
nodejs-10_x
nodejs-slim-10_x

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/41kv0xarxqh1a2qc6fgi977w7z7mwyn2-nodejs-slim-11.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A nodejs-slim-10_x https://github.com/r-ryantm/nixpkgs/archive/fae99b5d6709822bfcccdebf4a0c8010ac5190ea.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/41kv0xarxqh1a2qc6fgi977w7z7mwyn2-nodejs-slim-11.0.0
ls -la /nix/store/41kv0xarxqh1a2qc6fgi977w7z7mwyn2-nodejs-slim-11.0.0/bin

cc @cillianderoiste @gilligan @cko for testing.

@r-ryantm
nodejs-slim-10_x: 10.12.0 -> 11.0.0
fae99b5 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/nodejs-slim/versions
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodejs-slim-10_x

Partial log (click to expand)

patching script interpreter paths in /nix/store/d2bi9kxxkisapvpp3hjrbj0vbv9d3wk5-nodejs-slim-11.0.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d2bi9kxxkisapvpp3hjrbj0vbv9d3wk5-nodejs-slim-11.0.0
shrinking /nix/store/d2bi9kxxkisapvpp3hjrbj0vbv9d3wk5-nodejs-slim-11.0.0/bin/node
gzipping man pages under /nix/store/d2bi9kxxkisapvpp3hjrbj0vbv9d3wk5-nodejs-slim-11.0.0/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d2bi9kxxkisapvpp3hjrbj0vbv9d3wk5-nodejs-slim-11.0.0/bin
patching script interpreter paths in /nix/store/d2bi9kxxkisapvpp3hjrbj0vbv9d3wk5-nodejs-slim-11.0.0
checking for references to /build in /nix/store/d2bi9kxxkisapvpp3hjrbj0vbv9d3wk5-nodejs-slim-11.0.0...
/nix/store/d2bi9kxxkisapvpp3hjrbj0vbv9d3wk5-nodejs-slim-11.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nodejs-slim-10_x

Partial log (click to expand)

installing /nix/store/374kcgjbxkjwz48b357kqsbxhnrvh9ki-nodejs-slim-11.0.0/include/node/libplatform/libplatform-export.h
installing /nix/store/374kcgjbxkjwz48b357kqsbxhnrvh9ki-nodejs-slim-11.0.0/include/node/libplatform/libplatform.h
installing /nix/store/374kcgjbxkjwz48b357kqsbxhnrvh9ki-nodejs-slim-11.0.0/include/node/libplatform/v8-tracing.h
patching script interpreter paths in /nix/store/374kcgjbxkjwz48b357kqsbxhnrvh9ki-nodejs-slim-11.0.0
post-installation fixup
gzipping man pages under /nix/store/374kcgjbxkjwz48b357kqsbxhnrvh9ki-nodejs-slim-11.0.0/share/man/
strip is /nix/store/jicg9d0a282yzcig82308jf016iy4qk7-Toolchains/XcodeDefault.xctoolchain/bin/strip
stripping (with command strip and flags -S) in /nix/store/374kcgjbxkjwz48b357kqsbxhnrvh9ki-nodejs-slim-11.0.0/bin
patching script interpreter paths in /nix/store/374kcgjbxkjwz48b357kqsbxhnrvh9ki-nodejs-slim-11.0.0
/nix/store/374kcgjbxkjwz48b357kqsbxhnrvh9ki-nodejs-slim-11.0.0

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: nodejs-slim-10_x

Partial log (click to expand)

     return instance_type >= first_instance_type &&             \
../deps/v8/src/objects.h:1057:3: note: in expansion of macro 'INSTANCE_TYPE_CHECKER_RANGE'
   V(String, FIRST_TYPE, FIRST_NONSTRING_TYPE - 1)                   \
   ^
../deps/v8/src/objects-inl.h:98:1: note: in expansion of macro 'INSTANCE_TYPE_CHECKERS_RANGE'
 INSTANCE_TYPE_CHECKERS_RANGE(INSTANCE_TYPE_CHECKER_RANGE);
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  g++ -o /build/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/objects.o ../deps/v8/src/objects.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.5"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DENABLE_HANDLE_ZAPPING' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v11.0.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v11.0.0/out/Release/.deps//build/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/objects.o.d.raw   -c
building of '/nix/store/diz9n2j366ykdcni4v2z8c8ga3yliq92-nodejs-slim-11.0.0.drv' timed out after 3600 seconds
error: build of '/nix/store/diz9n2j366ykdcni4v2z8c8ga3yliq92-nodejs-slim-11.0.0.drv' failed

@adisbladis
Copy link
Member

@ryantm Could we ignore the nodejs*-slim attributes? Slim is just a variant on the nodejs package without npm so the commit messages could be better.

@ryantm ryantm mentioned this pull request Oct 27, 2018
Closed
@lo1tuma
Copy link
Member

lo1tuma commented Oct 27, 2018

I don’t think we want this change at all. nodejs-10_x shouldn’t be updated to a new major version.
#48911 introduces nodejs-11_x.

@gilligan
Copy link
Contributor

This indeed does indeed not make sense and should be closed in favor of #48911

@adisbladis adisbladis closed this Oct 27, 2018
@r-ryantm r-ryantm deleted the auto-update/nodejs-slim branch November 17, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @GrahamcOfBorg @adisbladis @lo1tuma @gilligan