New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firefox: fix darwin build #49226
firefox: fix darwin build #49226
Conversation
@matthewbauer Any idea what's going on here? I think the rust update broke this again, I get this failure now.
|
the build is broken on Linux too, also I'm not sure if it's related to this or not, but during the rust compilation part of the code, it seems to ignore |
Hmm, that's unexpected I tested firefox on linux with the rust update. What's the error? |
Sorry, never mind, it seems it builds fine now, although I haven't checked for the |
nix.cpp:2357:26: error: no member named 'CFURLCreateFromFSRef' in the global namespace CFURLRef newURLRef = ::CFURLCreateFromFSRef(kCFAllocatorDefault, aFSRef); ~~^ /private/tmp/nix-build-firefox-unwrapped-62.0.3.drv-0/firefox-62.0.3/xpcom/io/nsLocalFileUnix.cpp:2393:11: error: no member named 'CFURLGetFSRef' in the global namespace if (::CFURLGetFSRef(url, aResult)) { ~~^ 2 errors generated.
I tested this PR on macOS High Sierra (10.13.6), but the build still fails for me (output below).
|
This seems to be stalled and should probably be closed. @LnL7 |
Yeah, #63381 should make this partial fix unnecessary. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)