Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import LAST.FM backup files feature #441

Merged
merged 3 commits into from Oct 29, 2018

Conversation

FlyingTwigs
Copy link
Contributor

Summary

Since Last.FM removed their download scrobbles data, the function to import backup data in listenbrainz is pretty useless. So, it's better to remove this in order to not confuse people.

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:
    Deleted the function about import last.fm backup files

Problem

The deletion of the feature from last.fm make this functions pretty much useless.

  • JIRA ticket (optional): LB-379

Solution

Delete the functions

Action

Delete the functions

Copy link
Collaborator

@paramsingh paramsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, cleanup! 🥇

@paramsingh paramsingh merged commit 60cbc0a into metabrainz:master Oct 29, 2018
@FlyingTwigs
Copy link
Contributor Author

Thanks for the merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants