Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor another 130 python packages -> python-modules #49192

Closed
wants to merge 130 commits into from

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Oct 26, 2018

Things done

All have been tested to build and is ready for merge.

Strictly moving package to python-modules. Did not attempt to upgrade package unless it added python 3 support or was broken. Also converted fetch... to fetchPypi to make future upgrades easier. All packages have been tested in sandbox mode to build properly.

As of the last edit there are ~198 remaining packages to move.

grep "buildPythonPackage" ~/p/nixpkgs/pkgs/top-level/python-packages.nix | wc
    198    1026    8447
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc
Copy link
Member Author

costrouc commented Oct 26, 2018

Several packages fail to build due to dependencies (not changed in this commit) so they were broken before the commits. edit: I have confirmed that these packages are already failing in staging before my additions. Would a separate PR be appropriate for fixing these? Since it has nothing specifically to do with this PR.

  • fribidi-1.0.5 leads to pyacoustib, pydot_ng, pyqtgraph, qscintilla, runsnakerun, qutip to fail to build in 2.7 and 3.6

From `fribidi-1.0.51

WARNING: Unknown command line options: "auto_features"
This will become a hard error in a future Meson release.
Project name: fribidi
Native C compiler: /nix/store/10yq7kwlvbc6h658izmrlsspry1g9f3c-gcc-wrapper-7.3.0/bin/cc (gcc 7.3.0 "gcc (GCC) 7.3.0")
Build machine cpu family: x86_64
Build machine cpu: x86_64
Compiler for C supports arguments -ansi: YES
Compiler for C supports arguments -fvisibility=hidden: YES
Checking for function "memmove": YES
Checking for function "memset": YES
Checking for function "strdup": YES
Has header "stdlib.h": YES
Has header "string.h": YES
Has header "memory.h": YES
Has header "strings.h": YES
Has header "sys/times.h": YES
no configure script, doing nothing

  • pylint leads to pamqp to fail to build in 3.6
____________________ test_functional[missing_final_newline] ____________________

test_file = <test_functional.FunctionalTestFile object at 0x7ffff006bac8>

    @pytest.mark.parametrize("test_file", TESTS, ids=TESTS_NAMES)
    def test_functional(test_file):
        LintTest = LintModuleOutputUpdate(test_file) if UPDATE else LintModuleTest(test_file)
        LintTest.setUp()
>       LintTest._runTest()

pylint/test/test_functional.py:378:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <test_functional.LintModuleTest object at 0x7fffe500ef98>

    def _runTest(self):
        self._linter.check([self._test_file.module])

        expected_messages, expected_text = self._get_expected()
        received_messages, received_text = self._get_received()

        if expected_messages != received_messages:
            msg = ['Wrong results for file "%s":' % (self._test_file.base)]
            missing, unexpected = multiset_difference(expected_messages,
                                                      received_messages)
            if missing:
                msg.append('\nExpected in testdata:')
                msg.extend(' %3d: %s' % msg for msg in sorted(missing))
            if unexpected:
                msg.append('\nUnexpected in testdata:')
                msg.extend(' %3d: %s' % msg for msg in sorted(unexpected))
>           pytest.fail('\n'.join(msg))
E           Failed: Wrong results for file "missing_final_newline":
E
E           Unexpected in testdata:
E              4: mixed-line-endings

pylint/test/test_functional.py:322: Failed
  • entrypoints leads to robotoframework-tools to fail to build in 2.7
=================================== FAILURES ===================================
___________________________________ test_bad ___________________________________

    def test_bad():
        bad_path = [osp.join(samples_dir, 'packages3')]

        with warnings.catch_warnings(record=True) as w:
            group = entrypoints.get_group_named('entrypoints.test1', bad_path)

        assert 'bad' not in group
>       assert len(w) == 1
E       assert 2 == 1
E        +  where 2 = len([<warnings.WarningMessage object at 0x7ffff17852d0>, <warnings.WarningMessage object at 0x7ffff1766f10>])

I have confirmed that these packages are already failing in staging before my additions. Would a separate PR be appropriate for fixing these? Since it has nothing specifically to do with this PR.

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me like this, nice work!

@FRidh
Copy link
Member

FRidh commented Oct 27, 2018

Thanks. I've pushed these changes to staging.

@FRidh FRidh closed this Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants