Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brlaser: fix install dir #49180

Merged
merged 1 commit into from Nov 2, 2018
Merged

brlaser: fix install dir #49180

merged 1 commit into from Nov 2, 2018

Conversation

symphorien
Copy link
Member

Motivation for this change

Hopefully fixes #49092

The new tree is:

result
├── lib
│   └── cups
│       └── filter
│           └── rastertobrlaser
└── share
    └── cups
        └── drv
            └── brlaser.drv

without the strange $out dir.

@wagnerf42: can you check if this fixes you issue ?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@wagnerf42
Copy link

hi. sorry for the delay. since I'm new to nixos I took me some time to figure out how to test the change. It's ok ! thanks a lot.

@7c6f434c 7c6f434c merged commit bfd838a into NixOS:master Nov 2, 2018
@flokli
Copy link
Contributor

flokli commented Dec 19, 2018

backported to 18.09 in de20e95.

flokli added a commit that referenced this pull request Dec 19, 2018
This reverts commit 04405f6.

This was already fixed in #49180,
but never got backported to 18.09.
@symphorien symphorien deleted the issue-49092 branch May 18, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brlaser drivers not appearing
5 participants