Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03] apacheHttpd: 2.4.33 -> 2.4.35 #48238

Merged
merged 1 commit into from Oct 11, 2018
Merged

[18.03] apacheHttpd: 2.4.33 -> 2.4.35 #48238

merged 1 commit into from Oct 11, 2018

Conversation

andir
Copy link
Member

@andir andir commented Oct 11, 2018

Motivation for this change

Picked from master since it fixes CVE-2018-11763 which allows a remote
DoS against a server with HTTP/2 enabled.

Reference: https://lists.apache.org/thread.html/d435b0267a76501b9e06c552b20c887171064cde38e46d678da4d3dd@%3Cannounce.httpd.apache.org%3E

On 18.03 this also addresses CVE-2018-1333 & CVE-2018-8011

(cherry picked from commit 524c212)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@r-ryantm @andir
apacheHttpd: 2.4.33 -> 2.4.35
3359304 
Picked from master since it fixes CVE-2018-11763 which allows a remote
DoS against a server with HTTP/2 enabled.

Reference: https://lists.apache.org/thread.html/d435b0267a76501b9e06c552b20c887171064cde38e46d678da4d3dd@%3Cannounce.httpd.apache.org%3E

On 18.03 this also addresses CVE-2018-1333 & CVE-2018-8011

(cherry picked from commit 524c212)
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: apacheHttpd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/46j2m5a4cgz2c4m5434y5nzzvxcjnp2r-apache-httpd-2.4.35-man
gzipping man pages under /nix/store/46j2m5a4cgz2c4m5434y5nzzvxcjnp2r-apache-httpd-2.4.35-man/share/man/
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/46j2m5a4cgz2c4m5434y5nzzvxcjnp2r-apache-httpd-2.4.35-man
checking for references to /build in /nix/store/46j2m5a4cgz2c4m5434y5nzzvxcjnp2r-apache-httpd-2.4.35-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/k75nkwimnjd61cmla0jgwd5q1b2gysg2-apache-httpd-2.4.35-doc
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/k75nkwimnjd61cmla0jgwd5q1b2gysg2-apache-httpd-2.4.35-doc
checking for references to /build in /nix/store/k75nkwimnjd61cmla0jgwd5q1b2gysg2-apache-httpd-2.4.35-doc...
/nix/store/zgdljrdzv8vdgxra78s5y396r8axzrsz-apache-httpd-2.4.35

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: apacheHttpd

Partial log (click to expand)

patching script interpreter paths in /nix/store/gdpb5k35hy5kpr0yhjb8y3zw6gmcddpk-apache-httpd-2.4.35-dev
/nix/store/gdpb5k35hy5kpr0yhjb8y3zw6gmcddpk-apache-httpd-2.4.35-dev/share/build/config.nice: interpreter directive changed from " /bin/sh" to "/nix/store/3xp2dmql3fkv0mkfssszxdaxkhzcwzjk-bash-4.4-p12/bin/sh"
/nix/store/gdpb5k35hy5kpr0yhjb8y3zw6gmcddpk-apache-httpd-2.4.35-dev/share/build/instdso.sh: interpreter directive changed from "/bin/sh" to "/nix/store/3xp2dmql3fkv0mkfssszxdaxkhzcwzjk-bash-4.4-p12/bin/sh"
/nix/store/gdpb5k35hy5kpr0yhjb8y3zw6gmcddpk-apache-httpd-2.4.35-dev/share/build/mkdir.sh: interpreter directive changed from "/bin/sh" to "/nix/store/3xp2dmql3fkv0mkfssszxdaxkhzcwzjk-bash-4.4-p12/bin/sh"
gzipping man pages under /nix/store/kqblxbr9ypf1k2cj867z8iqg4xxy6h8f-apache-httpd-2.4.35-man/share/man/
strip is /nix/store/yjliwlfl3jlivmysq7372cxw4p42h92v-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/kqblxbr9ypf1k2cj867z8iqg4xxy6h8f-apache-httpd-2.4.35-man
strip is /nix/store/yjliwlfl3jlivmysq7372cxw4p42h92v-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/n2rvzqn5jvw3ld4s5d28p45l01277jk7-apache-httpd-2.4.35-doc
/nix/store/qbn5fbf6zhh16707b31gf2068fmrgm50-apache-httpd-2.4.35

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: apacheHttpd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/v4mbcmyl98fdrlb3rg608dpxxbkk8azb-apache-httpd-2.4.35-man
gzipping man pages under /nix/store/v4mbcmyl98fdrlb3rg608dpxxbkk8azb-apache-httpd-2.4.35-man/share/man/
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/v4mbcmyl98fdrlb3rg608dpxxbkk8azb-apache-httpd-2.4.35-man
checking for references to /build in /nix/store/v4mbcmyl98fdrlb3rg608dpxxbkk8azb-apache-httpd-2.4.35-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/amfrrcx6bwsfg4il37y69lap4n3lqzma-apache-httpd-2.4.35-doc
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/amfrrcx6bwsfg4il37y69lap4n3lqzma-apache-httpd-2.4.35-doc
checking for references to /build in /nix/store/amfrrcx6bwsfg4il37y69lap4n3lqzma-apache-httpd-2.4.35-doc...
/nix/store/ai76m6pm72l1hk9mq1y2csa78b8hnh5f-apache-httpd-2.4.35

@fpletz fpletz merged commit 4c229c3 into NixOS:release-18.03 Oct 11, 2018
@andir andir deleted the 18.03/apacheHttpd branch October 11, 2018 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @GrahamcOfBorg @fpletz @r-ryantm