Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options: Adds type information to the options list #246

Merged
merged 1 commit into from Mar 17, 2019
Merged

options: Adds type information to the options list #246

merged 1 commit into from Mar 17, 2019

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Oct 12, 2018 •
edited

The data was already available!

This uses the (possibly composed) description field from the types.

This was inspired by @ryantm who was curious about listing the type descriptions on the options page.

See NixOS/nixpkgs#48251 for better descriptions for separatedString.

Sneak peek

image

image

@samueldr
options: Adds type information to the options list
4e1a537 
The data was already available!

This uses the (possibly composed) description field from the types.
@samueldr samueldr mentioned this pull request Oct 12, 2018
Merged
@samueldr
Copy link
Member Author

samueldr commented Mar 3, 2019

@edolstra looks good to you?

@grahamc grahamc merged commit 52b2a6f into NixOS:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@dasJ dasJ dasJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samueldr @ryantm @dasJ @grahamc