nixos: initrd/luks: fix detection of devices by UUID #48229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#45998 has a small issue that causes the error shown in the first part of #47529. It assigns the output of
blkid
to a local variable and then tries to return its exit code. Sincelocal
is a command, it clobbers the value of$?
, so the function always returns 0.Things done
Since the local variable is never used, this PR removes it and redirects the output of
blkid
to/dev/null
. I also fixed some inconsistent indentation in the surrounding functions.sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)