Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube: bump version 0.29.0 -> 0.30.0 #48256

Merged
merged 1 commit into from Oct 12, 2018
Merged

minikube: bump version 0.29.0 -> 0.30.0 #48256

merged 1 commit into from Oct 12, 2018

Conversation

periklis
Copy link
Contributor

Motivation for this change

This is a fix release for CVE-2018-1002103. More details in
kubernetes/minikube#3208

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @copumpkin @ebzzry

@periklis
Copy link
Contributor Author

This is needs also backporting to 18.09

@srhb
Copy link
Contributor

srhb commented Oct 12, 2018

@GrahamcOfBorg build minikube

@srhb srhb self-assigned this Oct 12, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: minikube

Partial log (click to expand)

find: '/nix/store/qnyi44l2i6wdliwj6r50xx0ji59p2nhv-minikube-0.30.0': No such file or directory
find: '/nix/store/qnyi44l2i6wdliwj6r50xx0ji59p2nhv-minikube-0.30.0': No such file or directory
find: '/nix/store/qnyi44l2i6wdliwj6r50xx0ji59p2nhv-minikube-0.30.0': No such file or directory
find: '/nix/store/qnyi44l2i6wdliwj6r50xx0ji59p2nhv-minikube-0.30.0': No such file or directory
find: '/nix/store/qnyi44l2i6wdliwj6r50xx0ji59p2nhv-minikube-0.30.0': No such file or directory
find: '/nix/store/qnyi44l2i6wdliwj6r50xx0ji59p2nhv-minikube-0.30.0': No such file or directory
find: '/nix/store/qnyi44l2i6wdliwj6r50xx0ji59p2nhv-minikube-0.30.0': No such file or directory
find: '/nix/store/qnyi44l2i6wdliwj6r50xx0ji59p2nhv-minikube-0.30.0': No such file or directory
find: '/nix/store/qnyi44l2i6wdliwj6r50xx0ji59p2nhv-minikube-0.30.0': No such file or directory
/nix/store/ll6904v4q1kzxblaarfd3s8ggz06cd06-minikube-0.30.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: minikube

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/a7nfl59l0r625al6b2bgnv29nchdxvc8-minikube-0.30.0-bin
shrinking /nix/store/a7nfl59l0r625al6b2bgnv29nchdxvc8-minikube-0.30.0-bin/bin/minikube
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a7nfl59l0r625al6b2bgnv29nchdxvc8-minikube-0.30.0-bin/bin
patching script interpreter paths in /nix/store/a7nfl59l0r625al6b2bgnv29nchdxvc8-minikube-0.30.0-bin
checking for references to /build in /nix/store/a7nfl59l0r625al6b2bgnv29nchdxvc8-minikube-0.30.0-bin...
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: minikube

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/x4d0brkwvxvjgqhi9yhprpy0ks4a1rs9-minikube-0.30.0-bin
shrinking /nix/store/x4d0brkwvxvjgqhi9yhprpy0ks4a1rs9-minikube-0.30.0-bin/bin/minikube
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x4d0brkwvxvjgqhi9yhprpy0ks4a1rs9-minikube-0.30.0-bin/bin
patching script interpreter paths in /nix/store/x4d0brkwvxvjgqhi9yhprpy0ks4a1rs9-minikube-0.30.0-bin
checking for references to /build in /nix/store/x4d0brkwvxvjgqhi9yhprpy0ks4a1rs9-minikube-0.30.0-bin...
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip

@srhb srhb merged commit e960043 into NixOS:master Oct 12, 2018
srhb pushed a commit that referenced this pull request Oct 12, 2018
@periklis @srhb
minikube: bump version 0.29.0 -> 0.30.0
c0c867d 
This is a fix release for CVE-2018-1002103. More details in
kubernetes/minikube#3208

(cherry picked from commit e5ee89f)
Backport of #48256
@srhb
Copy link
Contributor

srhb commented Oct 12, 2018

Thanks!

@periklis
Copy link
Contributor Author

@srhb Do you need a PR for backporting to 18.09?

@srhb
Copy link
Contributor

srhb commented Oct 12, 2018

@periklis Nope, already done. Thanks though :)

c0c867d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@srhb srhb

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@periklis @srhb @GrahamcOfBorg