Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] nix-daemon service: Ensure ssh is on PATH. Fixes #46038. #48227

Merged
merged 1 commit into from Oct 11, 2018
Merged

[18.09] nix-daemon service: Ensure ssh is on PATH. Fixes #46038. #48227

merged 1 commit into from Oct 11, 2018

Conversation

infinisil
Copy link
Member

Motivation for this change

Backport of #46041

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@nh2 @infinisil
nix-daemon service: Ensure ssh is on PATH. Fixes NixOS#46038.
6e2c08b 
This fixes a regression introduced in commit
  700e21d

nix needs ssh on path for the SSH substituter functionality,
not only the distributed builds functionality.

Signed-off-by: Niklas Hambüchen <mail@nh2.me>
(cherry picked from commit 31919bc)
@infinisil infinisil merged commit b97b32c into NixOS:release-18.09 Oct 11, 2018
@infinisil infinisil deleted the issue-46038 branch October 11, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@infinisil @GrahamcOfBorg @nh2