Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam: refactor steam-runtime #49420

Closed
wants to merge 2 commits into from
Closed

steam: refactor steam-runtime #49420

wants to merge 2 commits into from

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Oct 29, 2018 •
edited

Overview of changes:

  • Use JSON instead of Nix for runtime-generated. The fetching of sources
    is done in runtime.nix.
  • runtime-generated now only specifies a path within the steamrt mirror,
    instead of the full url.
  • Automatically update the version (date) of steam-runtime.
  • Add a version to steam-runtime-wrapped.
  • Remove runtime-mirror.nix. There was no reference anywhere in nixpkgs.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: steam

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: steam

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@Synthetica9
Copy link
Member Author

cc @hrdinka @abbradar

@Synthetica9
steam: refactor steam-runtime
26fd3ee 
Overview of changes:

- Use JSON instead of Nix for runtime-generated. The fetching of sources
  is done in runtime.nix.
- runtime-generated now only specifies a path within the steamrt mirror,
  instead of the full url.
- Automatically update the version (date) of steam-runtime.
- Add a version to steam-runtime-wrapped.
- Remove runtime-mirror.nix. There was no reference anywhere in nixpkgs.
@Synthetica9 Synthetica9 mentioned this pull request Dec 4, 2018
Closed
@Synthetica9 Synthetica9 mentioned this pull request Dec 4, 2018
Closed
10 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

@hrdinka @abbradar are you ok to merge this as maintainers?
Seems ready to me.

@Synthetica9 Synthetica9 mentioned this pull request Dec 10, 2018
Merged
10 tasks
@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

Are there any updates on this pull request, please?

@infinisil
Copy link
Member

No activity in over a year, closing for now

@infinisil infinisil closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Synthetica9 @GrahamcOfBorg @c0bw3b @mmahut @infinisil