Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lib/base-small.nix #49410

Closed
wants to merge 1 commit into from
Closed

Update lib/base-small.nix #49410

wants to merge 1 commit into from

Conversation

edizuslu
Copy link

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@edolstra
Copy link
Member

Hm, what's the purpose of this file?

@joachifm
Copy link
Contributor

This appears to be taken from https://github.com/bjornfor/nixos-config/blob/master/cfg/base-small.nix. I'd say this is invalid, like the other recent invalid PRs.

@joachifm joachifm closed this Oct 29, 2018
@edizuslu
Copy link
Author

edizuslu commented Oct 29, 2018 via email

@joachifm
Copy link
Contributor

@edizuslu this repo is really easy to contribute to legitimately, there are tons of packages and you're almost certain to find a few that can be updated or improved in some other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
2.status: invalid 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@edizuslu @edolstra @joachifm @GrahamcOfBorg @Janik-Haag