nixos/lib/eval-config.nix: toString modulesPath #49401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing modulesPath in NixOS configurations can cause evaluation
errors in restricted mode. If used as `${modulesPath}` (as in all
use-sites in nixpkgs) the modules subtree is copied into its own store
path. Access to this path will be forbidden in restricted mode.
Converting to a string solves this issue.
`${builtins.toString modulesPath}` will point to a subdirectory of the
nixpkgs tree out of which evalModules is called.
This change converts modulesPath to a string by default so that the
call-site doesn't have to anymore.
aherrmann
force-pushed
the
stringify-modules-path
branch
from
8a2504a
to
044ceae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Referencing
modulesPathin NixOS configurations can cause evaluation errors in restricted mode.If used as
${modulesPath}(as in all use-sites innixpkgs) the modules subtree is copied into its own store path. Access to this path will be forbidden in restricted mode.Converting to a string solves this issue.
${builtins.toString modulesPath}will point to a subdirectory of the nixpkgs tree out of whichevalModulesis called.This change converts
modulesPathto a string by default so that the call-site doesn't have to anymore.Things done
sandboxinnix.confon non-NixOS)None of the tests seems to use
modulesPathdirectly. But, I pickednixos/tests/nsd.nixat random and it still passes.nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc @grahamc