Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmtp: 1.1.15 -> 1.1.16 #49411

Merged
merged 1 commit into from Nov 4, 2018
Merged

libmtp: 1.1.15 -> 1.1.16 #49411

merged 1 commit into from Nov 4, 2018

Conversation

timor
Copy link
Member

@timor timor commented Oct 29, 2018 •
edited

Motivation for this change

This fixes the problem of connecting android phones via MTP in kde/dolphin.

Symptom: clicking android device in plasma connection popup fails with something like

The file or folder udi=/org/kde/solid/udev/sys/devices/pci0000:00/0000:00:14.0/usb3/3-1 does not exist

Original Bug description: https://bugs.kde.org/show_bug.cgi?id=387454

Things done

Test procedure: built system (nixos-18.03, nixos-18.09) with updated package, reloaded udev rules,
watched mounting android device work

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timor
libmtp: 1.1.15 -> 1.1.16
79f148c 
This fixes the problem of connecting android phones via MTP in kde/dolphin.

Original Bug description: https://bugs.kde.org/show_bug.cgi?id=387454
@timor timor changed the title [WIP] libmtp: 1.1.15 -> 1.1.16 libmtp: 1.1.15 -> 1.1.16 Nov 2, 2018
@timor
Copy link
Member Author

timor commented Nov 2, 2018

I think this can be merged.

I think this should also be backported, at least to 18.09. Do I open a pull request against that branch?

c0bw3b
c0bw3b approved these changes Nov 4, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed a nox-review successfully

Result in /run/user/6666/nox-review-c8vyi0pu
total 0
lrwxrwxrwx 1 zzzz users 55  4 nov.  11:46 result -> /nix/store/g9scf6l98h8grvkl317xf14isvbccr2w-gvfs-1.36.2
lrwxrwxrwx 1 zzzz users 65  4 nov.  11:46 result-10 -> /nix/store/7i5iq7yj59h29744vnh8zym1b8imzdbp-amarok-2.9.0-20180618
lrwxrwxrwx 1 zzzz users 65  4 nov.  11:46 result-11 -> /nix/store/24mcy08clsbn9b5vx6n003ch5b7260iy-clementine-free-1.3.1
lrwxrwxrwx 1 zzzz users 53  4 nov.  11:46 result-12 -> /nix/store/hdv7cz8y4fdgd6q3bgvdn12mv502fkh9-mtpfs-1.1
lrwxrwxrwx 1 zzzz users 56  4 nov.  11:46 result-13 -> /nix/store/phb68b0cip271ak7zaglqw1m0dmivgs5-minitube-2.9
lrwxrwxrwx 1 zzzz users 60  4 nov.  11:46 result-14 -> /nix/store/4dbjf5z92v9g6qkaaai1cfm4n3sl75s6-qtscrobbler-0.11
lrwxrwxrwx 1 zzzz users 55  4 nov.  11:46 result-15 -> /nix/store/4bwzyp7657ybccb129scw9r1wz8bwbmf-gvfs-1.36.2
lrwxrwxrwx 1 zzzz users 55  4 nov.  11:46 result-16 -> /nix/store/0p02dw9z6alnhvysbd2kkrqhg4cp4gxq-atom-1.32.1
lrwxrwxrwx 1 zzzz users 73  4 nov.  11:46 result-17 -> /nix/store/shbnwp9sr7qz15lsrvmn9p41jhcdnsnv-phonon-backend-vlc-qt5-0.10.1
lrwxrwxrwx 1 zzzz users 66  4 nov.  11:46 result-18 -> /nix/store/ak98kw415gw8zmgri0km75imc606hpbm-atom-beta-1.33.0-beta1
lrwxrwxrwx 1 zzzz users 55  4 nov.  11:46 result-19 -> /nix/store/n2h70j86jva2mybnkgzkjhaff9s3ssmq-gmtp-1.3.11
lrwxrwxrwx 1 zzzz users 57  4 nov.  11:46 result-2 -> /nix/store/1x5vjs2mnkw7ikpd27dayinzl68bcyvg-tribler-7.1.2
lrwxrwxrwx 1 zzzz users 60  4 nov.  11:46 result-20 -> /nix/store/6k3gmkqf8s9jxc2phy47mc0rz134m7vj-rabbitvcs-0.17.1
lrwxrwxrwx 1 zzzz users 66  4 nov.  11:46 result-21 -> /nix/store/almc3p56y1q0pwvm132n5gbgivndxwwi-obs-linuxbrowser-0.5.2
lrwxrwxrwx 1 zzzz users 61  4 nov.  11:46 result-22 -> /nix/store/5xv29lgzi76mwprf5cyq7zd016lb7ak8-obs-studio-22.0.3
lrwxrwxrwx 1 zzzz users 53  4 nov.  11:46 result-23 -> /nix/store/q9lk3667jivprrznkjw4b51qii7cdsh8-vlc-3.0.4
lrwxrwxrwx 1 zzzz users 56  4 nov.  11:46 result-24 -> /nix/store/bqj2k71kpm0732m0162r7f4bbf913pyj-gigolo-0.4.2
lrwxrwxrwx 1 zzzz users 73  4 nov.  11:46 result-25 -> /nix/store/jxyp2znpxfk65fl16yyrwq13xw9jp72j-phonon-backend-vlc-qt4-0.10.1
lrwxrwxrwx 1 zzzz users 61  4 nov.  11:46 result-3-bin -> /nix/store/42z1pzsa11ih29wg3rqcrwgsijfnx7i8-libmtp-1.1.16-bin
lrwxrwxrwx 1 zzzz users 58  4 nov.  11:46 result-4 -> /nix/store/9w1zkv2dkzb55cfhgfg69gwlbhr7m0p9-calibre-3.31.0
lrwxrwxrwx 1 zzzz users 57  4 nov.  11:46 result-5 -> /nix/store/fqq9skpq31pv91w6pzfwfsanl8bs6g5n-spacefm-1.0.6
lrwxrwxrwx 1 zzzz users 57  4 nov.  11:46 result-6 -> /nix/store/fp7ypqln7ymfdgh5bix3nqzq2a2ysi0r-cantata-2.3.2
lrwxrwxrwx 1 zzzz users 84  4 nov.  11:46 result-7 -> /nix/store/vz0j9dz7dz99c4h93pk4v1wbnccgsg9x-far2l-2.1.unstable-2018-07-19.gitdceaa39
lrwxrwxrwx 1 zzzz users 54  4 nov.  11:46 result-8 -> /nix/store/rjwhmsw1b2s43g0yrq9as8315dcim12f-jmtpfs-0.5
lrwxrwxrwx 1 zzzz users 60  4 nov.  11:46 result-9 -> /nix/store/mymh4azs24sscbm0573xkm9b0f1984nn-megaglest-3.13.0

@c0bw3b c0bw3b merged commit f4508c4 into NixOS:master Nov 4, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 4, 2018

@timor yes open a new PR for backporting to release-18.09
Please use git cherry-pick -xe to backport the commit from this PR
https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches

@timor timor mentioned this pull request Nov 24, 2018
Merged
@timor timor deleted the libmtp-1.1.16 branch November 25, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timor @c0bw3b @GrahamcOfBorg