New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
texlive: provide repstopdf #49416
texlive: provide repstopdf #49416
Conversation
/cc @jabranham @7c6f434c |
@GrahamcOfBorg build texlive.combined.scheme-minimal texlive.combined.scheme-full |
Success on aarch64-linux (full log) Attempted: texlive.combined.scheme-minimal The following builds were skipped because they don't evaluate on aarch64-linux: texlive.combined.scheme-full Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
Judging by 7aa1404 this must be broken |
4bd82bf
to
640719b
Compare
Actually, the 7aa1404 doesn't enable restricted mode as well. |
Success on x86_64-linux (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
640719b
to
5579691
Compare
Please take a look at updated version. |
@GrahamcOfBorg build texlive.combined.scheme-minimal texlive.combined.scheme-full |
Failure on aarch64-linux (full log) Attempted: texlive.combined.scheme-minimal The following builds were skipped because they don't evaluate on aarch64-linux: texlive.combined.scheme-full Partial log (click to expand)
|
5579691
to
f3530ef
Compare
@GrahamcOfBorg build texlive.combined.scheme-minimal texlive.combined.scheme-full |
Success on aarch64-linux (full log) Attempted: texlive.combined.scheme-minimal The following builds were skipped because they don't evaluate on aarch64-linux: texlive.combined.scheme-full Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
@GrahamcOfBorg build texlive.combined.scheme-minimal texlive.combined.scheme-full |
Success on aarch64-linux (full log) Attempted: texlive.combined.scheme-minimal The following builds were skipped because they don't evaluate on aarch64-linux: texlive.combined.scheme-full Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
repstopdf is supposed to be a symlink to epstopdf. Then epstopdf looks at "$0" to detect when restricted mode needs to be enabled. Unfortunately our wrapper will drop all intermediate symlinks, which messes up "$0". Restricted mode appears to be a security feature, so a test is introduced to verify that the wrapper works as expected.
2bbb682
to
20643a7
Compare
@GrahamcOfBorg build texlive.combined.scheme-minimal texlive.combined.scheme-full |
Success on aarch64-linux (full log) Attempted: texlive.combined.scheme-minimal The following builds were skipped because they don't evaluate on aarch64-linux: texlive.combined.scheme-full Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
@GrahamcOfBorg build texlive.combined.scheme-minimal texlive.combined.scheme-full |
Success on aarch64-linux (full log) Attempted: texlive.combined.scheme-minimal The following builds were skipped because they don't evaluate on aarch64-linux: texlive.combined.scheme-full Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: texlive.combined.scheme-minimal, texlive.combined.scheme-full Partial log (click to expand)
|
@7c6f434c: no, it has never been applied; I don't think I've got non-trivial feedback about it until recently. |
@vcunat well, I did check it back in 2017 and posted the result in the old issue… Anyway, this PR now does take into account the code from the old patch, so do we declare the current state ready to merge? |
I'd say you merge what you consider best. I won't have time to dive into this, so I can't really say which approach (or their combination) is better. |
OK, the current state improves the situation, and now I don't see anything obvious to cross-check now. |
It is just a symlink to epstopdf. epstopdf will enable restricted modeUsually repstopdf is just a symlink to epstopdf. This will not work with our tricky wrappers. A care must be taken to ensure that restricted mode gets enabled.if exectuted as repstopdf.
Motivation for this change
Fix #49405
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)