Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zerotier: binds to network-online.target to avoid the 1m30s … #49423

Merged
merged 1 commit into from Nov 1, 2018
Merged

nixos/zerotier: binds to network-online.target to avoid the 1m30s … #49423

merged 1 commit into from Nov 1, 2018

Conversation

obadz
Copy link
Contributor

@obadz obadz commented Oct 29, 2018

…timeout before kill on shutdown.

Motivation for this change

Was very annoying to have to wait 1m30s every time I'm rebooting.

Also might help establishing connection to peers quicker though that doesn't seem rock solid yet.

Solution was suggested by zerotier/ZeroTierOne#738 (comment)

cc @jb55

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@obadz obadz merged commit c8c1ed2 into NixOS:master Nov 1, 2018
@obadz obadz deleted the zerotier-fix branch December 24, 2018 00:31
@chaseadam chaseadam mentioned this pull request Feb 12, 2019
Closed
@zimbatm
Copy link
Member

zimbatm commented Nov 27, 2019

This still happens sometimes to me:

Nov 27 13:52:18 no1 zerotier-one[1232]: sendto: Network is unreachable
Nov 27 13:55:36 no1 systemd[1]: Stopping ZeroTierOne...
Nov 27 13:57:06 no1 systemd[1]: zerotierone.service: State 'stop-sigterm' timed out. Killing.
Nov 27 13:57:06 no1 systemd[1]: zerotierone.service: Killing process 1232 (zerotier-one) with signal SIGKILL.
Nov 27 13:57:06 no1 systemd[1]: zerotierone.service: Main process exited, code=killed, status=9/KILL
Nov 27 13:57:06 no1 systemd[1]: zerotierone.service: Failed with result 'timeout'.
Nov 27 13:57:06 no1 systemd[1]: Stopped ZeroTierOne.
Nov 27 13:57:06 no1 systemd[1]: zerotierone.service: Consumed 1min 30.271s CPU time, no IP traffic.

I think the core issue is when the network is down, ZeroTier can go into a CPU loop and ignore the signals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@obadz @zimbatm @jb55 @GrahamcOfBorg