Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: fix "play" subcommand #49422

Merged
merged 1 commit into from Oct 29, 2018
Merged

crystal: fix "play" subcommand #49422

merged 1 commit into from Oct 29, 2018

Conversation

zarelit
Copy link
Member

@zarelit zarelit commented Oct 29, 2018

(backport of commit 473c890)

Motivation for this change

Backports #49252

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 29, 2018

@GrahamcOfBorg build crystal mint shards

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: crystal, mint, shards

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: crystal, shards

The following builds were skipped because they don't evaluate on x86_64-darwin: mint

Partial log (click to expand)

building
build flags: SHELL=/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash CRFLAGS=--release
crystal build src/shards.cr -o bin/shards --release
installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6raxi5jsnzmdih3wdzxy0qc6qcws0ayb-shards-0.8.1/bin
patching script interpreter paths in /nix/store/6raxi5jsnzmdih3wdzxy0qc6qcws0ayb-shards-0.8.1
/nix/store/143j7p0v3ggsnh9mwjkdi8xshampsw3v-crystal-0.26.0
/nix/store/6raxi5jsnzmdih3wdzxy0qc6qcws0ayb-shards-0.8.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: crystal, mint, shards

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9bv5pha5qazmgi60k268rharaihvknnp-shards-0.8.1
shrinking /nix/store/9bv5pha5qazmgi60k268rharaihvknnp-shards-0.8.1/bin/shards
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9bv5pha5qazmgi60k268rharaihvknnp-shards-0.8.1/bin
patching script interpreter paths in /nix/store/9bv5pha5qazmgi60k268rharaihvknnp-shards-0.8.1
checking for references to /build in /nix/store/9bv5pha5qazmgi60k268rharaihvknnp-shards-0.8.1...
/nix/store/qpah85bjiv857dybpl5kq3xgr2w932jr-crystal-0.26.0
/nix/store/4sl4s07anjnv7j7f51z9y4f7da0fbirf-mint-0.2.1
/nix/store/9bv5pha5qazmgi60k268rharaihvknnp-shards-0.8.1

@xeji xeji merged commit af7d54e into NixOS:release-18.09 Oct 29, 2018
@zarelit zarelit deleted the crystal_play_backport branch June 25, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zarelit @xeji @GrahamcOfBorg