gvfs: Fix-up paths to gio binary #48827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Oct 30, 2018
| @@ -82,6 +82,9 @@ stdenv.mkDerivation rec { | |||
| doInstallCheck = doCheck; | |||
|
|
|||
| preFixup = '' | |||
| for f in $out/bin/*; do | |||
| substituteInPlace $f --replace 'exec $replacement' 'exec ${glib.dev}/bin/$replacement' | |||
There was a problem hiding this comment.
How does replacing $replacement work?
There was a problem hiding this comment.
No magic: $replacement is just a shell variable reference inside the script, and it is always a shell command (starting with gio)
jtojnar
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#48547
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)