Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cedille bug fixes #48812

Merged
merged 2 commits into from Oct 24, 2018
Merged

cedille bug fixes #48812

merged 2 commits into from Oct 24, 2018

Conversation

mpickering
Copy link
Contributor

Motivation for this change

Without these two patches then it isn't possible to use any libraries with cedille.

cc @infinisil

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mpickering
cedille: Apply patch which unbreaks the options file
f7d4bc2 
See cedille/cedille#29
@mpickering
cedille: Make a seperate output for the base library
08e5ef2 
For now, for normal usage you need to add `${cedille.lib}` to
the `~/.cedille/options` file so that cedille will find the base
libraries. There is no option to pass options by the command line.
@joachifm
Copy link
Contributor

@GrahamcOfBorg build cedille

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cedille

Partial log (click to expand)

shrinking /nix/store/bm2dhi8iryvf4z4i5qvrakrcxs1f1yp1-cedille-1.0.0/bin/cedille
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bm2dhi8iryvf4z4i5qvrakrcxs1f1yp1-cedille-1.0.0/bin
patching script interpreter paths in /nix/store/bm2dhi8iryvf4z4i5qvrakrcxs1f1yp1-cedille-1.0.0
checking for references to /build in /nix/store/bm2dhi8iryvf4z4i5qvrakrcxs1f1yp1-cedille-1.0.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/cl3vfgsx9l7d7arjal2fz66gl0l7xlvq-cedille-1.0.0-lib
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/cl3vfgsx9l7d7arjal2fz66gl0l7xlvq-cedille-1.0.0-lib
checking for references to /build in /nix/store/cl3vfgsx9l7d7arjal2fz66gl0l7xlvq-cedille-1.0.0-lib...
/nix/store/bm2dhi8iryvf4z4i5qvrakrcxs1f1yp1-cedille-1.0.0

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: cedille

Partial log (click to expand)

ld: warning: /nix/store/fxnlihrix22xsxqkrq8gd3n9ym625868-libiconv-osx-10.11.6/lib/libiconv.dylib, ignoring unexpected dylib file
ld: warning: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation, ignoring unexpected dylib file
[250 of 338] Compiling Agda.TypeChecking.SizedTypes ( src/full/Agda/TypeChecking/SizedTypes.hs, dist/build/Agda/TypeChecking/SizedTypes.p_o )
clang-5.0: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
ld: warning: /nix/store/fxnlihrix22xsxqkrq8gd3n9ym625868-libiconv-osx-10.11.6/lib/libiconv.dylib, ignoring unexpected dylib file
ld: warning: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation, ignoring unexpected dylib file
building of '/nix/store/xs5qiiwrzyajhsl7xrpwvdc42a21zr3k-Agda-2.5.4.1.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/pmh63d2ggh69f6lw314mbfxb9fv4lqzb-cedille-1.0.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/pmh63d2ggh69f6lw314mbfxb9fv4lqzb-cedille-1.0.0.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: cedille

Partial log (click to expand)

cannot build derivation '/nix/store/2jy37hhz0zqnhz5sv70vcgnw68p7sar0-unordered-containers-0.2.9.0.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/4k8w83v3xyf542sgd0gg56fgj31wn9q0-tasty-1.1.0.4.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/zn65aqia4radmjf56ryx06zlbmml020l-uri-encode-1.5.0.5.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/23w2nabmxvkgfninaanwl11vjndjp3yy-tasty-hunit-0.10.0.1.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/z5askw0aa84n0v1ka8iq5yz85s9chqh9-tasty-quickcheck-0.10.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/842cqzrar15ri3qlhmmya7zn7slnk4yw-blaze-markup-0.8.2.2.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/29276k4vqr6v2q598zqpvc3933iyxigy-blaze-html-0.9.1.1.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/fg1a55b79ycrrhbas6y9lg6hvgc0l7aq-Agda-2.5.4.1.drv': 24 dependencies couldn't be built
cannot build derivation '/nix/store/8rq3g9kgkcbhczipnbdiar3b1qqx8pcy-cedille-1.0.0.drv': 4 dependencies couldn't be built
error: build of '/nix/store/8rq3g9kgkcbhczipnbdiar3b1qqx8pcy-cedille-1.0.0.drv' failed

@joachifm joachifm merged commit b6a5cd8 into NixOS:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mpickering @joachifm @GrahamcOfBorg @infinisil