Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] ghc: add new 8.4.4 version #48806

Merged
merged 1 commit into from Nov 10, 2018

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Oct 22, 2018

Motivation for this change

Ensure that 18.09 users have access to GHC 8.4.4, which includes several important bugfixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

(cherry picked from commit 069bf7a)
@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

cc @peti

@srhb
Copy link
Contributor

srhb commented Oct 30, 2018

cc @basvandijk ?

@unode unode mentioned this pull request Nov 2, 2018
@basvandijk
Copy link
Member

@GrahamcOfBorg build haskell.compiler.ghc844

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghc844

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskell.compiler.ghc844

Partial log (click to expand)

these paths will be fetched (115.68 MiB download, 1288.40 MiB unpacked):
  /nix/store/51qagmpgkh0c3d6mhbipfmip7ccfybzn-ghc-8.4.4
  /nix/store/phlh1mayxzra4jvhx833myyvjbdyyvhw-gmp-6.1.2-dev
  /nix/store/zh7zygc1xw9i44py01vwqgdmpfy9rz0g-ghc-8.4.4-doc
copying path '/nix/store/zh7zygc1xw9i44py01vwqgdmpfy9rz0g-ghc-8.4.4-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/phlh1mayxzra4jvhx833myyvjbdyyvhw-gmp-6.1.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/51qagmpgkh0c3d6mhbipfmip7ccfybzn-ghc-8.4.4' from 'https://cache.nixos.org'...
/nix/store/51qagmpgkh0c3d6mhbipfmip7ccfybzn-ghc-8.4.4

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: haskell.compiler.ghc844

Partial log (click to expand)

<<ghc: 1675683712 bytes, 170 GCs, 15386550/53817456 avg/max bytes residency (8 samples), 111M in use, 0.000 INIT (0.000 elapsed), 1.454 MUT (1.753 elapsed), 0.647 GC (0.684 elapsed) :ghc>>
"inplace/bin/ghc-stage1" -hisuf hi -osuf  o -hcsuf hc -static  -H32m -O -Wall   -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header   -this-unit-id ghc-8.4.4 -hide-all-packages -i -icompiler/backpack -icompiler/basicTypes -icompiler/cmm -icompiler/codeGen -icompiler/coreSyn -icompiler/deSugar -icompiler/ghci -icompiler/hsSyn -icompiler/iface -icompiler/llvmGen -icompiler/main -icompiler/nativeGen -icompiler/parser -icompiler/prelude -icompiler/profiling -icompiler/rename -icompiler/simplCore -icompiler/simplStg -icompiler/specialise -icompiler/stgSyn -icompiler/stranal -icompiler/typecheck -icompiler/types -icompiler/utils -icompiler/vectorise -icompiler/stage2/build -Icompiler/stage2/build -icompiler/stage2/build/./autogen -Icompiler/stage2/build/./autogen -Icompiler/. -Icompiler/parser -Icompiler/utils -Icompiler/../rts/dist/build -Icompiler/stage2 -Icompiler/stage2/build/. -Icompiler/stage2/build/parser -Icompiler/stage2/build/utils -Icompiler/stage2/build/../rts/dist/build -Icompiler/stage2/build/stage2   -optP-DGHCI -optP-include -optPcompiler/stage2/build/./autogen/cabal_macros.h -package-id base-4.11.1.0 -package-id deepseq-1.4.3.0 -package-id directory-1.3.1.5 -package-id process-1.6.3.0 -package-id bytestring-0.10.8.2 -package-id binary-0.8.5.1 -package-id time-1.8.0.2 -package-id containers-0.5.11.0 -package-id array-0.5.2.0 -package-id filepath-1.4.2 -package-id template-haskell-2.13.0.0 -package-id hpc-0.6.0.3 -package-id transformers-0.5.5.0 -package-id ghc-boot-8.4.4 -package-id ghc-boot-th-8.4.4 -package-id ghci-8.4.4 -package-id unix-2.7.2.2 -package-id terminfo-0.4.1.1 -Wall -Wno-name-shadowing -Wnoncanonical-monad-instances -Wnoncanonical-monadfail-instances -Wnoncanonical-monoid-instances -this-unit-id ghc -XHaskell2010 -XNoImplicitPrelude -optc-DTHREADED_RTS -DGHCI_TABLES_NEXT_TO_CODE -DSTAGE=2 -Rghc-timing -O2 -Wcpp-undef  -no-user-package-db -rtsopts       -Wnoncanonical-monad-instances  -odir compiler/stage2/build -hidir compiler/stage2/build -stubdir compiler/stage2/build   -dynamic-too -c compiler/vectorise/Vectorise/Vect.hs -o compiler/stage2/build/Vectorise/Vect.o -dyno compiler/stage2/build/Vectorise/Vect.dyn_o
<<ghc: 181190760 bytes, 51 GCs, 4344824/10474400 avg/max bytes residency (4 samples), 32M in use, 0.000 INIT (0.000 elapsed), 0.123 MUT (0.176 elapsed), 0.059 GC (0.066 elapsed) :ghc>>
"inplace/bin/ghc-stage1" -hisuf hi -osuf  o -hcsuf hc -static  -H32m -O -Wall      -this-unit-id Cabal-2.2.0.1 -hide-all-packages -i -ilibraries/Cabal/Cabal/. -ilibraries/Cabal/Cabal/dist-install/build -Ilibraries/Cabal/Cabal/dist-install/build -ilibraries/Cabal/Cabal/dist-install/build/./autogen -Ilibraries/Cabal/Cabal/dist-install/build/./autogen -Ilibraries/Cabal/Cabal/.    -optP-include -optPlibraries/Cabal/Cabal/dist-install/build/./autogen/cabal_macros.h -package-id array-0.5.2.0 -package-id base-4.11.1.0 -package-id bytestring-0.10.8.2 -package-id containers-0.5.11.0 -package-id deepseq-1.4.3.0 -package-id filepath-1.4.2 -package-id pretty-1.1.3.6 -package-id process-1.6.3.0 -package-id time-1.8.0.2 -package-id transformers-0.5.5.0 -package-id mtl-2.2.2 -package-id text-1.2.3.1 -package-id parsec-3.1.13.0 -package-id directory-1.3.1.5 -package-id binary-0.8.5.1 -package-id unix-2.7.2.2 -Wall -fno-ignore-asserts -fwarn-tabs -Wcompat -Wnoncanonical-monad-instances -Wnoncanonical-monadfail-instances -XHaskell2010 -O2  -no-user-package-db -rtsopts  -Wno-deprecated-flags     -Wnoncanonical-monad-instances  -odir libraries/Cabal/Cabal/dist-install/build -hidir libraries/Cabal/Cabal/dist-install/build -stubdir libraries/Cabal/Cabal/dist-install/build  -split-sections -dynamic-too -c libraries/Cabal/Cabal/./Distribution/Simple/LocalBuildInfo.hs -o libraries/Cabal/Cabal/dist-install/build/Distribution/Simple/LocalBuildInfo.o -dyno libraries/Cabal/Cabal/dist-install/build/Distribution/Simple/LocalBuildInfo.dyn_o
"inplace/bin/ghc-stage1" -hisuf p_hi -osuf  p_o -hcsuf p_hc -static -prof -eventlog  -H32m -O -Wall      -this-unit-id Cabal-2.2.0.1 -hide-all-packages -i -ilibraries/Cabal/Cabal/. -ilibraries/Cabal/Cabal/dist-install/build -Ilibraries/Cabal/Cabal/dist-install/build -ilibraries/Cabal/Cabal/dist-install/build/./autogen -Ilibraries/Cabal/Cabal/dist-install/build/./autogen -Ilibraries/Cabal/Cabal/.    -optP-include -optPlibraries/Cabal/Cabal/dist-install/build/./autogen/cabal_macros.h -package-id array-0.5.2.0 -package-id base-4.11.1.0 -package-id bytestring-0.10.8.2 -package-id containers-0.5.11.0 -package-id deepseq-1.4.3.0 -package-id filepath-1.4.2 -package-id pretty-1.1.3.6 -package-id process-1.6.3.0 -package-id time-1.8.0.2 -package-id transformers-0.5.5.0 -package-id mtl-2.2.2 -package-id text-1.2.3.1 -package-id parsec-3.1.13.0 -package-id directory-1.3.1.5 -package-id binary-0.8.5.1 -package-id unix-2.7.2.2 -Wall -fno-ignore-asserts -fwarn-tabs -Wcompat -Wnoncanonical-monad-instances -Wnoncanonical-monadfail-instances -XHaskell2010 -O2  -no-user-package-db -rtsopts  -Wno-deprecated-flags     -Wnoncanonical-monad-instances  -odir libraries/Cabal/Cabal/dist-install/build -hidir libraries/Cabal/Cabal/dist-install/build -stubdir libraries/Cabal/Cabal/dist-install/build  -split-sections  -c libraries/Cabal/Cabal/./Distribution/Backpack/Id.hs -o libraries/Cabal/Cabal/dist-install/build/Distribution/Backpack/Id.p_o -dyno libraries/Cabal/Cabal/dist-install/build/Distribution/Backpack/Id.dyn_o
"inplace/bin/ghc-stage1" -hisuf p_hi -osuf  p_o -hcsuf p_hc -static -prof -eventlog  -H32m -O -Wall      -this-unit-id Cabal-2.2.0.1 -hide-all-packages -i -ilibraries/Cabal/Cabal/. -ilibraries/Cabal/Cabal/dist-install/build -Ilibraries/Cabal/Cabal/dist-install/build -ilibraries/Cabal/Cabal/dist-install/build/./autogen -Ilibraries/Cabal/Cabal/dist-install/build/./autogen -Ilibraries/Cabal/Cabal/.    -optP-include -optPlibraries/Cabal/Cabal/dist-install/build/./autogen/cabal_macros.h -package-id array-0.5.2.0 -package-id base-4.11.1.0 -package-id bytestring-0.10.8.2 -package-id containers-0.5.11.0 -package-id deepseq-1.4.3.0 -package-id filepath-1.4.2 -package-id pretty-1.1.3.6 -package-id process-1.6.3.0 -package-id time-1.8.0.2 -package-id transformers-0.5.5.0 -package-id mtl-2.2.2 -package-id text-1.2.3.1 -package-id parsec-3.1.13.0 -package-id directory-1.3.1.5 -package-id binary-0.8.5.1 -package-id unix-2.7.2.2 -Wall -fno-ignore-asserts -fwarn-tabs -Wcompat -Wnoncanonical-monad-instances -Wnoncanonical-monadfail-instances -XHaskell2010 -O2  -no-user-package-db -rtsopts  -Wno-deprecated-flags     -Wnoncanonical-monad-instances  -odir libraries/Cabal/Cabal/dist-install/build -hidir libraries/Cabal/Cabal/dist-install/build -stubdir libraries/Cabal/Cabal/dist-install/build  -split-sections  -c libraries/Cabal/Cabal/./Distribution/Backpack/ComponentsGraph.hs -o libraries/Cabal/Cabal/dist-install/build/Distribution/Backpack/ComponentsGraph.p_o -dyno libraries/Cabal/Cabal/dist-install/build/Distribution/Backpack/ComponentsGraph.dyn_o
"inplace/bin/ghc-stage1" -hisuf p_hi -osuf  p_o -hcsuf p_hc -static -prof -eventlog  -H32m -O -Wall      -this-unit-id Cabal-2.2.0.1 -hide-all-packages -i -ilibraries/Cabal/Cabal/. -ilibraries/Cabal/Cabal/dist-install/build -Ilibraries/Cabal/Cabal/dist-install/build -ilibraries/Cabal/Cabal/dist-install/build/./autogen -Ilibraries/Cabal/Cabal/dist-install/build/./autogen -Ilibraries/Cabal/Cabal/.    -optP-include -optPlibraries/Cabal/Cabal/dist-install/build/./autogen/cabal_macros.h -package-id array-0.5.2.0 -package-id base-4.11.1.0 -package-id bytestring-0.10.8.2 -package-id containers-0.5.11.0 -package-id deepseq-1.4.3.0 -package-id filepath-1.4.2 -package-id pretty-1.1.3.6 -package-id process-1.6.3.0 -package-id time-1.8.0.2 -package-id transformers-0.5.5.0 -package-id mtl-2.2.2 -package-id text-1.2.3.1 -package-id parsec-3.1.13.0 -package-id directory-1.3.1.5 -package-id binary-0.8.5.1 -package-id unix-2.7.2.2 -Wall -fno-ignore-asserts -fwarn-tabs -Wcompat -Wnoncanonical-monad-instances -Wnoncanonical-monadfail-instances -XHaskell2010 -O2  -no-user-package-db -rtsopts  -Wno-deprecated-flags     -Wnoncanonical-monad-instances  -odir libraries/Cabal/Cabal/dist-install/build -hidir libraries/Cabal/Cabal/dist-install/build -stubdir libraries/Cabal/Cabal/dist-install/build  -split-sections  -c libraries/Cabal/Cabal/./Distribution/Simple/BuildPaths.hs -o libraries/Cabal/Cabal/dist-install/build/Distribution/Simple/BuildPaths.p_o -dyno libraries/Cabal/Cabal/dist-install/build/Distribution/Simple/BuildPaths.dyn_o
"inplace/bin/ghc-stage1" -hisuf p_hi -osuf  p_o -hcsuf p_hc -static -prof -eventlog  -H32m -O -Wall      -this-unit-id Cabal-2.2.0.1 -hide-all-packages -i -ilibraries/Cabal/Cabal/. -ilibraries/Cabal/Cabal/dist-install/build -Ilibraries/Cabal/Cabal/dist-install/build -ilibraries/Cabal/Cabal/dist-install/build/./autogen -Ilibraries/Cabal/Cabal/dist-install/build/./autogen -Ilibraries/Cabal/Cabal/.    -optP-include -optPlibraries/Cabal/Cabal/dist-install/build/./autogen/cabal_macros.h -package-id array-0.5.2.0 -package-id base-4.11.1.0 -package-id bytestring-0.10.8.2 -package-id containers-0.5.11.0 -package-id deepseq-1.4.3.0 -package-id filepath-1.4.2 -package-id pretty-1.1.3.6 -package-id process-1.6.3.0 -package-id time-1.8.0.2 -package-id transformers-0.5.5.0 -package-id mtl-2.2.2 -package-id text-1.2.3.1 -package-id parsec-3.1.13.0 -package-id directory-1.3.1.5 -package-id binary-0.8.5.1 -package-id unix-2.7.2.2 -Wall -fno-ignore-asserts -fwarn-tabs -Wcompat -Wnoncanonical-monad-instances -Wnoncanonical-monadfail-instances -XHaskell2010 -O2  -no-user-package-db -rtsopts  -Wno-deprecated-flags     -Wnoncanonical-monad-instances  -odir libraries/Cabal/Cabal/dist-install/build -hidir libraries/Cabal/Cabal/dist-install/build -stubdir libraries/Cabal/Cabal/dist-install/build  -split-sections  -c libraries/Cabal/Cabal/./Distribution/Simple/Program/Ld.hs -o libraries/Cabal/Cabal/dist-install/build/Distribution/Simple/Program/Ld.p_o -dyno libraries/Cabal/Cabal/dist-install/build/Distribution/Simple/Program/Ld.dyn_o
building of '/nix/store/f02ncnyk5j2msvn4kz4g052ww06qii27-ghc-8.4.4.drv' timed out after 1800 seconds
error: build of '/nix/store/f02ncnyk5j2msvn4kz4g052ww06qii27-ghc-8.4.4.drv' failed

@samueldr samueldr merged commit aa8c4f3 into NixOS:release-18.09 Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants