Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cypari2: 1.2.1 -> 1.3.1 #48824

Merged
merged 2 commits into from Oct 22, 2018
Merged

pythonPackages.cypari2: 1.2.1 -> 1.3.1 #48824

merged 2 commits into from Oct 22, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 22, 2018 •
edited

Motivation for this change

The sage fix is unrelated, I just noticed the error here and needed to fix it in order to test the cypari upgrade.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
sage: fix doctest
db75fe7 
The test is depending on the "py2" tag always being added. I patched
that recently to make it possible to test sagedoc individually. Somehow
I missed this doctest.
@timokau
pythonPackages.cypari2: 1.2.1 -> 1.3.1
9512841
@timokau timokau requested a review from FRidh as a code owner October 22, 2018 12:55
@timokau timokau merged commit c4650da into NixOS:master Oct 22, 2018
@timokau timokau deleted the cypari2-update branch October 22, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau