Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gocode: 2018-07-27 -> 2018-10-22 #48832

Merged
merged 1 commit into from Oct 23, 2018
Merged

gocode: 2018-07-27 -> 2018-10-22 #48832

merged 1 commit into from Oct 23, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Oct 22, 2018 •
edited

github.com/nsf/gocode has also been deprecated in favor of github.com/mdempsky/gocode

Please backport this to 18.09 because I could not use the deoplete-go vim plugin with the current version of gocode as it panics on Go 1.11.

Motivation for this change

Fix deoplete-go vim plugin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@kalbasit
gocode: 2018-07-27 -> 2018-10-22
fae75e3 
github.com/nsf/gocode has also been deprecated in favor of github.com/mdempsky/gocode
kalbasit added a commit to kalbasit/shabka that referenced this pull request Oct 22, 2018
@kalbasit
home: neovim: install the direnv plugin
c359bc7 
The root cause of my issue was not the direnv plugin, but it was caused
by the move of all of my packages to NUR at
b7302f0 which has reverted my gocode
changes.

I filed NixOS/nixpkgs#48832 upstream to fix this
issue for everyone.

This reverts commit 5c05593.
@kalbasit
Copy link
Member Author

@GrahamcOfBorg build gocode

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gocode

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i8yw4niz54ca8n0fsjk1jwx531wp0409-gocode-unstable-2018-10-22-bin
shrinking /nix/store/i8yw4niz54ca8n0fsjk1jwx531wp0409-gocode-unstable-2018-10-22-bin/bin/gocode
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i8yw4niz54ca8n0fsjk1jwx531wp0409-gocode-unstable-2018-10-22-bin/bin
patching script interpreter paths in /nix/store/i8yw4niz54ca8n0fsjk1jwx531wp0409-gocode-unstable-2018-10-22-bin
checking for references to /build in /nix/store/i8yw4niz54ca8n0fsjk1jwx531wp0409-gocode-unstable-2018-10-22-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/i8yw4niz54ca8n0fsjk1jwx531wp0409-gocode-unstable-2018-10-22-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gocode

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin
shrinking /nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin/bin/gocode
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin/bin
patching script interpreter paths in /nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin
checking for references to /build in /nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gocode

Partial log (click to expand)

/nix/store/i8yw4niz54ca8n0fsjk1jwx531wp0409-gocode-unstable-2018-10-22-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gocode

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin
shrinking /nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin/bin/gocode
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin/bin
patching script interpreter paths in /nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin
checking for references to /build in /nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/pmr6zd4w1cps8w0m8i1s7lxnqx4wngrq-gocode-unstable-2018-10-22-bin

@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

@GrahamcOfBorg build ycmd vimPlugins.youcompleteme

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ycmd, vimPlugins.youcompleteme

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xa8mwr041c5gzkp5wj5qfv4fdai68d4b-vimplugin-youcompleteme-2018-09-20
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/xa8mwr041c5gzkp5wj5qfv4fdai68d4b-vimplugin-youcompleteme-2018-09-20
/nix/store/xa8mwr041c5gzkp5wj5qfv4fdai68d4b-vimplugin-youcompleteme-2018-09-20/share/vim-plugins/youcompleteme/print_todos.sh: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/xa8mwr041c5gzkp5wj5qfv4fdai68d4b-vimplugin-youcompleteme-2018-09-20/share/vim-plugins/youcompleteme/install.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/xa8mwr041c5gzkp5wj5qfv4fdai68d4b-vimplugin-youcompleteme-2018-09-20/share/vim-plugins/youcompleteme/.circleci/install_dependencies.sh: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/xa8mwr041c5gzkp5wj5qfv4fdai68d4b-vimplugin-youcompleteme-2018-09-20...
/nix/store/8khagzq3hj8qb2z74dl04q83ykxmwc7b-ycmd-2018-09-20
/nix/store/xa8mwr041c5gzkp5wj5qfv4fdai68d4b-vimplugin-youcompleteme-2018-09-20

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ycmd, vimPlugins.youcompleteme

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h77pn3cd7grypnmc3vn28hsn67amd20m-vimplugin-youcompleteme-2018-09-20
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/h77pn3cd7grypnmc3vn28hsn67amd20m-vimplugin-youcompleteme-2018-09-20
/nix/store/h77pn3cd7grypnmc3vn28hsn67amd20m-vimplugin-youcompleteme-2018-09-20/share/vim-plugins/youcompleteme/install.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/h77pn3cd7grypnmc3vn28hsn67amd20m-vimplugin-youcompleteme-2018-09-20/share/vim-plugins/youcompleteme/print_todos.sh: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/h77pn3cd7grypnmc3vn28hsn67amd20m-vimplugin-youcompleteme-2018-09-20/share/vim-plugins/youcompleteme/.circleci/install_dependencies.sh: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/h77pn3cd7grypnmc3vn28hsn67amd20m-vimplugin-youcompleteme-2018-09-20...
/nix/store/yj9dhjxxc3413gckc3nl0pv7gfzwm0gx-ycmd-2018-09-20
/nix/store/h77pn3cd7grypnmc3vn28hsn67amd20m-vimplugin-youcompleteme-2018-09-20

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: ycmd, vimPlugins.youcompleteme

Partial log (click to expand)

t1010-mktree.sh .................................... ok
t1011-read-tree-sparse-checkout.sh ................. ok
t1012-read-tree-df.sh .............................. ok
building of '/nix/store/6kl1pd2wyngah7s4kvc9kf08pm4vyj6b-git-2.19.1.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/ndiac27h0k88cb5f6ms1511dqqd9x8rs-rustc-1.29.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3vw7d8l20cjdvarfs38c4ky8l5zp72hg-cargo-1.29.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/6rh2gvr66s1djlkd48klx8qqbahv6bcf-racerd-2017-09-15.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/f6cppdplw2j9vny74b7gwarpf5gc900l-ycmd-2018-09-20.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/cygak27ndq5zv4n25dpxkcnlyjnlbcsj-vimplugin-youcompleteme-2018-09-20.drv': 1 dependencies couldn't be built
error: build of '/nix/store/cygak27ndq5zv4n25dpxkcnlyjnlbcsj-vimplugin-youcompleteme-2018-09-20.drv', '/nix/store/f6cppdplw2j9vny74b7gwarpf5gc900l-ycmd-2018-09-20.drv' failed

@xeji xeji merged commit cc4b9ef into NixOS:master Oct 23, 2018
xeji pushed a commit that referenced this pull request Oct 23, 2018
@kalbasit @xeji
gocode: 2018-07-27 -> 2018-10-22 (#48832)
c162a0a 
github.com/nsf/gocode has also been deprecated in favor of github.com/mdempsky/gocode

(cherry picked from commit cc4b9ef)
@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

backported in c162a0a

@kalbasit kalbasit deleted the nixpkgs_update-gocode branch October 23, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @GrahamcOfBorg @xeji