Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] slimserver: Relax audio scan dependency (#47029) #48831

Merged
merged 1 commit into from Oct 22, 2018
Merged

[18.09] slimserver: Relax audio scan dependency (#47029) #48831

merged 1 commit into from Oct 22, 2018

Conversation

nyanloutre
Copy link
Member

Motivation for this change

Fix broken slimserver service

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 22, 2018

Can you cherry-pick using the -x option so it also includes the backport commit?

@nyanloutre
Copy link
Member Author

@Mic92 done

@Mic92 Mic92 merged commit 09bc130 into NixOS:release-18.09 Oct 22, 2018
@nyanloutre nyanloutre deleted the 18-09-slimserver-fix branch October 22, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @Mic92 @GrahamcOfBorg @phile314