Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jackett: 0.10.304 -> 0.10.365 #48821

Merged
merged 2 commits into from Oct 23, 2018
Merged

jackett: 0.10.304 -> 0.10.365 #48821

merged 2 commits into from Oct 23, 2018

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Oct 22, 2018 •
edited

Motivation for this change

Fixes for several trackers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 22, 2018

@GrahamcOfBorg build jackett

@Mic92
Copy link
Member

Mic92 commented Oct 22, 2018

Can you also add to the wrapper to work-around the mono bug?

--set TERM "xterm"

$ Jackett
Unhandled Exception:
System.TypeInitializationException: The type initializer for 'System.Console' threw an exception. ---> System.Ty
peInitializationException: The type initializer for 'System.ConsoleDriver' threw an exception. ---> System.Excep
tion: Magic number is wrong: 542
  at System.TermInfoReader.ReadHeader (System.Byte[] buffer, System.Int32& position) [0x00028] in <e5c02814e3c34
fcca1c8854c186e5844>:0
  at System.TermInfoReader..ctor (System.String term, System.String filename) [0x0005f] in <e5c02814e3c34fcca1c8
854c186e5844>:0
  at System.TermInfoDriver..ctor (System.String term) [0x00055] in <e5c02814e3c34fcca1c8854c186e5844>:0
  at System.ConsoleDriver.CreateTermInfoDriver (System.String term) [0x00000] in <e5c02814e3c34fcca1c8854c186e58
44>:0
  at System.ConsoleDriver..cctor () [0x0004d] in <e5c02814e3c34fcca1c8854c186e5844>:0
...

@nyanloutre
Copy link
Member Author

@Mic92 does this bug also affect 18.09 ?

@nyanloutre
Copy link
Member Author

Maybe the solution would be to use mono version 5.14 as this bug was fixed by mono/mono@2c1f45f

@Mic92
Copy link
Member

Mic92 commented Oct 22, 2018

Maybe. Do we have this mono version? 18.09 should be affected as well.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: jackett

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jackett

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/grp9l0cis8349ypq04qv8s46kvdg0xrx-jackett-0.10.365
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/grp9l0cis8349ypq04qv8s46kvdg0xrx-jackett-0.10.365/bin
patching script interpreter paths in /nix/store/grp9l0cis8349ypq04qv8s46kvdg0xrx-jackett-0.10.365
/nix/store/grp9l0cis8349ypq04qv8s46kvdg0xrx-jackett-0.10.365/share/jackett-0.10.365/install_service_macos: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/grp9l0cis8349ypq04qv8s46kvdg0xrx-jackett-0.10.365...
/nix/store/grp9l0cis8349ypq04qv8s46kvdg0xrx-jackett-0.10.365

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: jackett

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/lpqcy0wdkakhh3zmfslkm3dpj8nczxvs-jackett-0.10.365/bin
patching script interpreter paths in /nix/store/lpqcy0wdkakhh3zmfslkm3dpj8nczxvs-jackett-0.10.365
/nix/store/lpqcy0wdkakhh3zmfslkm3dpj8nczxvs-jackett-0.10.365/share/jackett-0.10.365/install_service_macos: interpreter directive changed from "/bin/bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/lpqcy0wdkakhh3zmfslkm3dpj8nczxvs-jackett-0.10.365

@nyanloutre
Copy link
Member Author

@Mic92 it should work now

nyanloutre added a commit to nyanloutre/nixpkgs that referenced this pull request Oct 23, 2018
@nyanloutre
jackett: update mono version to 5.14
2b4f746 
See details here : NixOS#48821 (comment)

(cherry picked from commit 7a44e6e)
@Mic92
Copy link
Member

Mic92 commented Oct 23, 2018

We should really make this the default. But upgrading mono in nixpkgs is such a pain.

@nyanloutre
Copy link
Member Author

Is there many breaking changes between mono versions ?

@Mic92
Copy link
Member

Mic92 commented Oct 23, 2018

Not so many actually. I tried to remove old mono versions but we have some projects that are no longer maintained and not compatible with later releases. We should probably remove those.

@Mic92 Mic92 merged commit e82af60 into NixOS:master Oct 23, 2018
@nyanloutre nyanloutre deleted the jackett-10-365 branch October 23, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @Mic92 @GrahamcOfBorg