New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sway-beta: init at 1.0-beta1 #48829
sway-beta: init at 1.0-beta1 #48829
Conversation
Note that the maintainer asks distributions not to package the betas (as with previous alphas): Package maintainers: please do not package this release. Source: https://github.com/swaywm/sway/releases Just in case you missed it. Can't wait until Sway hits 1.0 either though ;). |
I preemptively asked for the author's position on that in the freenode/#sway irc channel:
|
Honestly not sure if the ofborg eval is failing because of this pr, or because master is failing in general |
c6a89f0
to
2f8eee3
Compare
2f8eee3
to
d5a4ed7
Compare
Success on aarch64-linux (full log) Attempted: meson, systemd The following builds were skipped because they don't evaluate on aarch64-linux: sway-beta Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: meson, systemd The following builds were skipped because they don't evaluate on x86_64-linux: sway-beta Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: sway-beta Partial log (click to expand)
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: sway-beta Partial log (click to expand)
|
The dependency |
wlroots 0.1 is a tagged release, and the upstream author #38344 (comment) doesn't mind us trying it. So I think we can remove the |
@GrahamcOfBorg build sway-beta |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: sway-beta Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: sway-beta Partial log (click to expand)
|
@GrahamcOfBorg build sway |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: sway Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: sway Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: sway-beta Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: sway Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: sway-beta Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: sway-beta Partial log (click to expand)
|
Git isn't really required. You can set 'sway-version' in meson flags. I'm
not sure how it would work just including git since it won't have the git
directory to determine the version tag/commit.
…On Tue, Oct 23, 2018, 4:44 AM xeji ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#48829 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAT9dAzkyYDlCrnYpWbzjNmYlG83Hfhuks5unwEngaJpZM4Xzu6D>
.
|
Hey *, sorry I wasn't aware of this PR @colemickens thanks for CCing me :) @Synthetica9 thanks for asking Drew, you can remove |
See 7307d80
See #48869 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind creating a new file beta.nix
(or something similar) for Sway 1.0? In general it is a good idea to avoid redundancy but in this case we don't need to maintain 0.15.x for long and the build system changed. IMO it would therefore be cleaner to use a separate file (even though there will be some redundancy).
Instead of Git (not required) you can use the following: mesonFlags = [ "-Dsway-version=${version}" ];
. And the build workflow for the man pages changed as well (they now require scdoc
). You can have a look at https://github.com/primeos/nixpkgs-primeos/blob/master/default.nix#L75 if you want (it's probably not perfect, as I didn't check if all dependencies are still required (etc.), but it works).
Sure thing, working on it.
Did that in 7307d80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as some sort of checklist ;) (you're probably still working on it)
Success on x86_64-linux (full log) Attempted: sway, sway-beta Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: sway, sway-beta Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: sway, sway-beta Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: sway, sway-beta Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, thanks :)
I'll test it quickly, mind if I squash and merge to have a clean history? |
Yeah, a squash is probably warranted. |
Ok, it worked fine :) |
Motivation for this change
Based on the meson and systemd update from #46020, reccomend merging that first.Not anymore, due to f4615beThings done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)