live555: 2018.02.28 -> 2018.10.17 #48825

peterhoeg · 2018-10-22T13:10:15Z

Motivation for this change

CVE-2018-4013 which has gotten a bit of attention these last few days.

Needs backporting to stable when all tests pass. Only consumer in nixpkgs is vlc.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-10-22T19:04:42Z

Failure on aarch64-linux (full log)

Attempted: live555

Partial log (click to expand)

g++: error: unrecognized command line option '-m64'
make[1]: *** [Makefile:32: H265VideoStreamFramer.o] Error 1
g++: error: unrecognized command line option '-m64'
g++: error: unrecognized command line option '-m64'
make[1]: *** [Makefile:32: H265VideoStreamDiscreteFramer.o] Error 1
make[1]: *** [Makefile:32: MPEGVideoStreamParser.o] Error 1
make[1]: Leaving directory '/build/live/liveMedia'
make: *** [Makefile:33: all] Error 2
builder for '/nix/store/iy00p4qbd5dcixxbngm6q3kxd8rxaqq4-live555-2018.10.17.drv' failed with exit code 2
error: build of '/nix/store/iy00p4qbd5dcixxbngm6q3kxd8rxaqq4-live555-2018.10.17.drv' failed

GrahamcOfBorg · 2018-10-22T19:04:50Z

Success on x86_64-linux (full log)

Attempted: live555

Partial log (click to expand)


For more information about this source code (including your obligations under the LGPL), please see our FAQ at http://live555.com/liveMedia/faq.html
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9q3054sam63vmv65jk2y0q2f67sffhzk-live555-2018.10.17
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9q3054sam63vmv65jk2y0q2f67sffhzk-live555-2018.10.17/lib  /nix/store/9q3054sam63vmv65jk2y0q2f67sffhzk-live555-2018.10.17/bin
patching script interpreter paths in /nix/store/9q3054sam63vmv65jk2y0q2f67sffhzk-live555-2018.10.17
checking for references to /build in /nix/store/9q3054sam63vmv65jk2y0q2f67sffhzk-live555-2018.10.17...
/nix/store/9q3054sam63vmv65jk2y0q2f67sffhzk-live555-2018.10.17

peterhoeg · 2018-10-22T23:34:27Z

@GrahamcOfBorg build vlc

GrahamcOfBorg · 2018-10-22T23:34:45Z

Failure on aarch64-linux (full log)

Attempted: vlc

Partial log (click to expand)

copying path '/nix/store/i812ngm6ir7ngk2m952j0sansc4mkxyn-ffmpeg-3.4.4-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/2yc48ngrijmasgivdfqcvqxm65a0zdz1-qtbase-5.11.1-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/rix1fi337qx4yrh0yvhka1slar4n441c-qtsvg-5.11.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/5w52rvcf11lfqfa9kiwpkm8arr7i4in5-qtx11extras-5.11.1' from 'https://cache.nixos.org'...
copying path '/nix/store/qvydz4cchzxgzznw68argq64kf1lvg20-ffmpeg-3.4.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/g2myszr05ka24nvx3wfzy1165jrmakid-samba-4.7.10-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/b1iz6iln0qgw79wrzl8mrah76ip7ij3a-qtsvg-5.11.1-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/x4g5dz1cva1s25akdh1g2vvqsw6f0yxw-qtx11extras-5.11.1-dev' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/wfcxz2vlxcagbzika0yr4hb0sadvkr11-vlc-3.0.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/wfcxz2vlxcagbzika0yr4hb0sadvkr11-vlc-3.0.4.drv' failed

GrahamcOfBorg · 2018-10-22T23:48:31Z

Success on x86_64-linux (full log)

Attempted: live555

Partial log (click to expand)

/nix/store/9q3054sam63vmv65jk2y0q2f67sffhzk-live555-2018.10.17

GrahamcOfBorg · 2018-10-22T23:48:32Z

Failure on aarch64-linux (full log)

Attempted: live555

Partial log (click to expand)

make[1]: *** [Makefile:33: Media.o] Error 127
make[1]: *** Waiting for unfinished jobs....
/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash: arm-elf-g++: command not found
make[1]: *** [Makefile:33: MediaSource.o] Error 127
/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash: arm-elf-g++: command not found
make[1]: *** [Makefile:33: FramedSource.o] Error 127
make[1]: Leaving directory '/build/live/liveMedia'
make: *** [Makefile:34: all] Error 2
builder for '/nix/store/9wvx70c2pfjbszqfxl0jsxn9jpwhdal2-live555-2018.10.17.drv' failed with exit code 2
error: build of '/nix/store/9wvx70c2pfjbszqfxl0jsxn9jpwhdal2-live555-2018.10.17.drv' failed

GrahamcOfBorg · 2018-10-23T00:28:06Z

Success on x86_64-linux (full log)

Attempted: vlc

Partial log (click to expand)

/nix/store/pc2qsqyf75l57prazzackgqqd52mgr8j-vlc-3.0.4/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pc2qsqyf75l57prazzackgqqd52mgr8j-vlc-3.0.4/share/vlc/utils/gnome-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pc2qsqyf75l57prazzackgqqd52mgr8j-vlc-3.0.4/share/vlc/utils/video-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pc2qsqyf75l57prazzackgqqd52mgr8j-vlc-3.0.4/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pc2qsqyf75l57prazzackgqqd52mgr8j-vlc-3.0.4/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pc2qsqyf75l57prazzackgqqd52mgr8j-vlc-3.0.4/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pc2qsqyf75l57prazzackgqqd52mgr8j-vlc-3.0.4/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/pc2qsqyf75l57prazzackgqqd52mgr8j-vlc-3.0.4...
postPatchMkspecs
/nix/store/pc2qsqyf75l57prazzackgqqd52mgr8j-vlc-3.0.4

peterhoeg · 2018-10-23T04:43:26Z

@GrahamcOfBorg build vlc

GrahamcOfBorg · 2018-10-23T04:43:36Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: vlc

Partial log (click to expand)

Cannot nix-instantiate `vlc' because:
error: while evaluating the attribute 'LIVE555_PREFIX' of the derivation 'vlc-3.0.4' at /var/lib/gc-of-borg/nix-test-rs-23/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-23/pkgs/stdenv/generic/make-derivation.nix:178:11:
undefined variable 'live555' at /var/lib/gc-of-borg/nix-test-rs-23/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-23/pkgs/applications/video/vlc/default.nix:49:20

GrahamcOfBorg · 2018-10-23T04:43:38Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: vlc

Partial log (click to expand)

Cannot nix-instantiate `vlc' because:
error: while evaluating the attribute 'LIVE555_PREFIX' of the derivation 'vlc-3.0.4' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/stdenv/generic/make-derivation.nix:178:11:
undefined variable 'live555' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/applications/video/vlc/default.nix:49:20

peterhoeg · 2018-10-23T04:52:43Z

@GrahamcOfBorg build vlc

GrahamcOfBorg · 2018-10-23T05:03:06Z

Success on aarch64-linux (full log)

Attempted: vlc

Partial log (click to expand)

/nix/store/31h5kj2s0k686w6yhqjy1rlv6zqh66xs-vlc-3.0.4/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/31h5kj2s0k686w6yhqjy1rlv6zqh66xs-vlc-3.0.4/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/31h5kj2s0k686w6yhqjy1rlv6zqh66xs-vlc-3.0.4/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/31h5kj2s0k686w6yhqjy1rlv6zqh66xs-vlc-3.0.4/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/31h5kj2s0k686w6yhqjy1rlv6zqh66xs-vlc-3.0.4/share/vlc/utils/video-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/31h5kj2s0k686w6yhqjy1rlv6zqh66xs-vlc-3.0.4/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/31h5kj2s0k686w6yhqjy1rlv6zqh66xs-vlc-3.0.4/share/vlc/utils/gnome-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/31h5kj2s0k686w6yhqjy1rlv6zqh66xs-vlc-3.0.4...
postPatchMkspecs
/nix/store/31h5kj2s0k686w6yhqjy1rlv6zqh66xs-vlc-3.0.4

GrahamcOfBorg · 2018-10-23T05:03:09Z

Failure on aarch64-linux (full log)

Attempted: live555, vlc

Partial log (click to expand)

make[1]: *** [Makefile:33: Media.o] Error 127
make[1]: *** Waiting for unfinished jobs....
/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash: arm-elf-g++: command not found
make[1]: *** [Makefile:33: MediaSource.o] Error 127
/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash: arm-elf-g++: command not found
make[1]: *** [Makefile:33: FramedSource.o] Error 127
make[1]: Leaving directory '/build/live/liveMedia'
make: *** [Makefile:34: all] Error 2
builder for '/nix/store/9wvx70c2pfjbszqfxl0jsxn9jpwhdal2-live555-2018.10.17.drv' failed with exit code 2
error: build of '/nix/store/9wvx70c2pfjbszqfxl0jsxn9jpwhdal2-live555-2018.10.17.drv' failed

GrahamcOfBorg · 2018-10-23T05:07:51Z

Success on x86_64-linux (full log)

Attempted: live555, vlc

Partial log (click to expand)

/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/share/vlc/utils/video-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4...
postPatchMkspecs
/nix/store/9q3054sam63vmv65jk2y0q2f67sffhzk-live555-2018.10.17
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4

GrahamcOfBorg · 2018-10-23T05:43:43Z

Success on x86_64-linux (full log)

Attempted: vlc

Partial log (click to expand)

/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/share/vlc/utils/gnome-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/share/vlc/utils/video-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4...
postPatchMkspecs
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4

peterhoeg · 2018-10-23T06:37:14Z

I think it's more important to get vlc working on aarch64 than have live555 support. If somebody cares a lot, we can always reintroduce live555 support.

peterhoeg · 2018-10-23T06:38:54Z

Cc: @matthewbauer

GrahamcOfBorg · 2018-10-23T06:49:28Z

Success on x86_64-linux (full log)

Attempted: live555, vlc

Partial log (click to expand)

/nix/store/9q3054sam63vmv65jk2y0q2f67sffhzk-live555-2018.10.17
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4

GrahamcOfBorg · 2018-10-23T06:49:31Z

Failure on aarch64-linux (full log)

Attempted: live555, vlc

Partial log (click to expand)

g++: error: unrecognized command line option '-m64'
make[1]: *** [Makefile:32: H264VideoStreamDiscreteFramer.o] Error 1
g++: error: unrecognized command line option '-m64'
make[1]: *** [Makefile:32: MPEG1or2AudioStreamFramer.o] Error 1
g++: error: unrecognized command line option '-m64'
make[1]: *** [Makefile:32: MPEGVideoStreamParser.o] Error 1
make[1]: Leaving directory '/build/live/liveMedia'
make: *** [Makefile:33: all] Error 2
builder for '/nix/store/iy00p4qbd5dcixxbngm6q3kxd8rxaqq4-live555-2018.10.17.drv' failed with exit code 2
error: build of '/nix/store/iy00p4qbd5dcixxbngm6q3kxd8rxaqq4-live555-2018.10.17.drv' failed

GrahamcOfBorg · 2018-10-23T06:54:35Z

Success on x86_64-linux (full log)

Attempted: live555, vlc

Partial log (click to expand)

/nix/store/9q3054sam63vmv65jk2y0q2f67sffhzk-live555-2018.10.17
/nix/store/6bhz6w5paf7z1cpkb5awrlbkjhmxy290-vlc-3.0.4

GrahamcOfBorg · 2018-10-23T06:54:39Z

Failure on aarch64-linux (full log)

Attempted: live555, vlc

Partial log (click to expand)

g++: error: unrecognized command line option '-m64'
make[1]: *** [Makefile:32: H264or5VideoStreamDiscreteFramer.o] Error 1
make[1]: *** [Makefile:32: H265VideoStreamDiscreteFramer.o] Error 1
make[1]: *** [Makefile:32: MPEGVideoStreamParser.o] Error 1
g++: error: unrecognized command line option '-m64'
make[1]: *** [Makefile:32: H265VideoStreamFramer.o] Error 1
make[1]: Leaving directory '/build/live/liveMedia'
make: *** [Makefile:33: all] Error 2
builder for '/nix/store/iy00p4qbd5dcixxbngm6q3kxd8rxaqq4-live555-2018.10.17.drv' failed with exit code 2
error: build of '/nix/store/iy00p4qbd5dcixxbngm6q3kxd8rxaqq4-live555-2018.10.17.drv' failed

timokau · 2018-11-18T12:48:14Z

We should also mark live555 as broken on aarch64.

c0bw3b · 2018-11-18T16:59:57Z

~~>> #50612

seghers · 2021-09-08T14:36:59Z

I think it's more important to get vlc working on aarch64 than have live555 support. If somebody cares a lot, we can always reintroduce live555 support.

@peterhoeg I'd like to use rtsp on rpi4. How could I reintroduce live555 support for aarch64?

live555: 2018.02.28 -> 2018.10.17

c06ca5f

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Oct 22, 2018

vlc: remove live555 to make it compile on arm

60cb7f7

peterhoeg force-pushed the u/live555 branch from 2863879 to 60cb7f7 Compare October 23, 2018 06:38

c0bw3b mentioned this pull request Nov 18, 2018

trivial: random fixes #50491

Merged

c0bw3b mentioned this pull request Nov 18, 2018

live555: 2018.02.28 -> 2018.10.17 #50612

Merged

9 tasks

c0bw3b closed this Nov 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

live555: 2018.02.28 -> 2018.10.17 #48825

live555: 2018.02.28 -> 2018.10.17 #48825

peterhoeg commented Oct 22, 2018 •

edited

GrahamcOfBorg commented Oct 22, 2018

GrahamcOfBorg commented Oct 22, 2018

peterhoeg commented Oct 22, 2018

GrahamcOfBorg commented Oct 22, 2018

GrahamcOfBorg commented Oct 22, 2018

GrahamcOfBorg commented Oct 22, 2018

GrahamcOfBorg commented Oct 23, 2018

peterhoeg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

peterhoeg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

peterhoeg commented Oct 23, 2018

peterhoeg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

timokau commented Nov 18, 2018

c0bw3b commented Nov 18, 2018

seghers commented Sep 8, 2021

live555: 2018.02.28 -> 2018.10.17 #48825

live555: 2018.02.28 -> 2018.10.17 #48825

Conversation

peterhoeg commented Oct 22, 2018 • edited

Motivation for this change

Things done

GrahamcOfBorg commented Oct 22, 2018

GrahamcOfBorg commented Oct 22, 2018

peterhoeg commented Oct 22, 2018

GrahamcOfBorg commented Oct 22, 2018

GrahamcOfBorg commented Oct 22, 2018

GrahamcOfBorg commented Oct 22, 2018

GrahamcOfBorg commented Oct 23, 2018

peterhoeg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

peterhoeg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

peterhoeg commented Oct 23, 2018

peterhoeg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

GrahamcOfBorg commented Oct 23, 2018

timokau commented Nov 18, 2018

c0bw3b commented Nov 18, 2018

seghers commented Sep 8, 2021

peterhoeg commented Oct 22, 2018 •

edited