Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make-system-tarball.sh: double quote to prevent globbing and word splitting. #49427

Closed
wants to merge 2 commits into from
Closed

make-system-tarball.sh: double quote to prevent globbing and word splitting. #49427

wants to merge 2 commits into from

Conversation

mztriz
Copy link

@mztriz mztriz commented Oct 29, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mztriz
SC2086: Double quote to prevent globbing and word splitting.
a49ecfb 
SC2086: Double quote to prevent globbing and word splitting.
@mztriz
SC2086: Double quote to prevent globbing and word splitting.
450c8ea 
SC2086: Double quote to prevent globbing and word splitting.
matthewbauer
matthewbauer reviewed Oct 29, 2018
View reviewed changes
nixos/lib/make-system-tarball.sh
fi
done

$extraCommands
"$extraCommands"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The others look good but I think this one needs to be left unquoted. For instance this script fails in bash:

> extraCommands='echo 1'
> "$extraCommands"
test.sh: line 3: echo 1: command not found

Because it thinks echo 1 is a path name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an eval "$extraCommands" would do?

@Mic92 Mic92 changed the title SC2086: Double quote to prevent globbing and word splitting. make-system-tarball.sh: Double quote to prevent globbing and word splitting. Oct 30, 2018
@Mic92 Mic92 changed the title make-system-tarball.sh: Double quote to prevent globbing and word splitting. make-system-tarball.sh: double quote to prevent globbing and word splitting. Oct 30, 2018
dingxiangfei2009
dingxiangfei2009 reviewed Oct 31, 2018
View reviewed changes
nixos/lib/make-system-tarball.sh

sources_=($sources)
targets_=($targets)

echo $objects
echo "$objects"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting to ✂️ this line altogether. This is only for debugging, I believe.

@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

Are there any updates on this pull request, please?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@Artturin Artturin closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@dingxiangfei2009 dingxiangfei2009 dingxiangfei2009 left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mztriz @mmahut @matthewbauer @dingxiangfei2009 @ryantm @GrahamcOfBorg @Artturin @Janik-Haag