-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osmium-tool: init at 1.9.1 incl. dependencies #49429
Conversation
@GrahamcOfBorg build protozero libosmium osmium-tool |
description = "Fast and flexible C++ library for working with OpenStreetMap data"; | ||
homepage = "https://osmcode.org/libosmium/"; | ||
licence = stdenv.lib.licences.boost; | ||
maintainers = with stdenv.maintainers; [ das-g ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdenv.lib.maintainers
description = "Multipurpose command line tool for working with OpenStreetMap data based on the Osmium library"; | ||
homepage = "https://osmcode.org/osmium-tool/"; | ||
license = with stdenv.lib.licenses; [ gpl3 mit bsd3 ]; | ||
maintainers = with stdenv.maintainers; [ das-g ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdenv.lib.maintainers
Success on aarch64-linux (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
How can I reproduce the failures repored by @GrahamcOfBorg locally? Neither nix build -f $PATH_TO_LOCAL_nixpkgs_CLONE/ osmium-tool nor cd $PATH_TO_LOCAL_nixpkgs_CLONE/
nix run nixpkgs.nox -c nox-review wip --against origin/master gave me these errors. |
@das-g https://github.com/NixOS/ofborg#running-meta-checks-locally -- or you can try to |
@GrahamcOfBorg eval |
meta = with stdenv.lib; { | ||
description = "Fast and flexible C++ library for working with OpenStreetMap data"; | ||
homepage = "https://osmcode.org/libosmium/"; | ||
licence = licences.boost; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: should be "licenses"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I fix this in a new commit, or — as this was never a valid meta attributes set — rewrite the commit that introduced the typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to squash it into the existing commit. I'd prefer we end up with just the four, one for each application and the maintainer addition. :)
1ea0469
to
295cae7
Compare
@GrahamcOfBorg build protozero libosmium osmium-tool |
Success on x86_64-darwin (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
Motivation for this change
I'd like to use the osmium CLI tool for analyzing OpenStreetMap data or for preprocessing it for use in other analyzing software.
Things done
sandbox
innix.conf
on non-NixOS)nix run nixpkgs.nox -c nox-review wip --against origin/master
./result/bin/
)nix path-info -S
before and after)Note that the various optional dependencies of libosmium aren't supported by this PR, yet.