osmium-tool: init at 1.9.1 incl. dependencies #49429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build protozero libosmium osmium-tool |
srhb
requested changes
Nov 2, 2018
| description = "Fast and flexible C++ library for working with OpenStreetMap data"; | ||
| homepage = "https://osmcode.org/libosmium/"; | ||
| licence = stdenv.lib.licences.boost; | ||
| maintainers = with stdenv.maintainers; [ das-g ]; |
| description = "Multipurpose command line tool for working with OpenStreetMap data based on the Osmium library"; | ||
| homepage = "https://osmcode.org/osmium-tool/"; | ||
| license = with stdenv.lib.licenses; [ gpl3 mit bsd3 ]; | ||
| maintainers = with stdenv.maintainers; [ das-g ]; |
|
Success on aarch64-linux (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
|
How can I reproduce the failures repored by @GrahamcOfBorg locally? Neither nix build -f $PATH_TO_LOCAL_nixpkgs_CLONE/ osmium-toolnor cd $PATH_TO_LOCAL_nixpkgs_CLONE/
nix run nixpkgs.nox -c nox-review wip --against origin/mastergave me these errors. |
|
@das-g https://github.com/NixOS/ofborg#running-meta-checks-locally -- or you can try to |
|
@GrahamcOfBorg eval |
das-g
commented
Nov 2, 2018
| meta = with stdenv.lib; { | ||
| description = "Fast and flexible C++ library for working with OpenStreetMap data"; | ||
| homepage = "https://osmcode.org/libosmium/"; | ||
| licence = licences.boost; |
There was a problem hiding this comment.
Should I fix this in a new commit, or — as this was never a valid meta attributes set — rewrite the commit that introduced the typo?
There was a problem hiding this comment.
Feel free to squash it into the existing commit. I'd prefer we end up with just the four, one for each application and the maintainer addition. :)
das-g
force-pushed
the
osmium
branch
2 times, most recently
from
1ea0469
to
295cae7
Compare
|
@GrahamcOfBorg build protozero libosmium osmium-tool |
|
Success on x86_64-darwin (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: protozero, libosmium, osmium-tool Partial log (click to expand)
|
srhb
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'd like to use the osmium CLI tool for analyzing OpenStreetMap data or for preprocessing it for use in other analyzing software.
Things done
sandboxinnix.confon non-NixOS)nix run nixpkgs.nox -c nox-review wip --against origin/master./result/bin/)nix path-info -Sbefore and after)Note that the various optional dependencies of libosmium aren't supported by this PR, yet.