Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R: update CRAN package set to snapshot 2018-10-28 #49430

Closed
wants to merge 2 commits into from
Closed

R: update CRAN package set to snapshot 2018-10-28 #49430

wants to merge 2 commits into from

Conversation

thomasjm
Copy link
Contributor

Motivation for this change

I wanted to pick up some new R packages that were added since the last snapshot in July. Never done this before, please let me know if I'm missing some test procedure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@thomasjm thomasjm requested a review from peti as a code owner October 29, 2018 23:26
@peti
Copy link
Member

peti commented Oct 30, 2018

Have you run the evaluation test that is explained in the documentation?

@thomasjm
Copy link
Contributor Author

Sorry, didn't see that. Ran into some errors, trying to sort it out now...

@thomasjm
Copy link
Contributor Author

Okay, I think things are good now. I had to regenerate the other packages and remove a few things from default.nix that don't seem to exist anymore.

@peti
Copy link
Member

peti commented Nov 1, 2018

I merged peti@98c6796 into the r-updates branch for testing. The builds are running at https://hydra.nixos.org/jobset/nixpkgs/r-updates. Let's see how well the new versions work ...

@peti peti closed this in cac5c94 Nov 2, 2018
thomasjm added a commit to codedownio/nixpkgs that referenced this pull request Dec 19, 2018
@thomasjm
R: update CRAN and BIOC package sets
60eef2a 
Closes NixOS#49430.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thomasjm @peti @GrahamcOfBorg @Janik-Haag