Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clustergit: init at 2018-04-18 #49457

Closed
wants to merge 1 commit into from
Closed

clustergit: init at 2018-04-18 #49457

wants to merge 1 commit into from

Conversation

gmarmstrong
Copy link
Contributor

Motivation for this change

Add the clustergit command-line utility (a tool for running Git commands on multiple repositories at once) to the available packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.


stdenv.mkDerivation rec {
name = "clustergit-${version}";
version = "2018-04-18";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not a proper release, the version should be unstable-2018-04-18

@@ -0,0 +1,26 @@
{ stdenv, fetchFromGitHub }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required python dependencies missing

sha256 = "10v5zq5m1mpzr1xr8y7dkxw654wl9r0hp7n64g4nbjx2ay26yyy4";
};

installPhase = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here (or during some fixup phase) the script should be properly wrapped with a python with all the required packages available using eg. wrapProgram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants