pythonPackages.entrypoints: fix python2 build #49458
Conversation
The recent pytest upgrade in bea4b36 broke the test suite.
|
@timokau python-unstable branch isn't a continuously used branch and often force pushed to as well. If you have a large rebuild, it should target staging instead. |
| # path. The pytest upgrade added some warning, resulting in two warnings | ||
| # being thrown. | ||
| # upstream: https://github.com/takluyver/entrypoints/issues/23 | ||
| pyTestArgs = if isPy27 then "-k 'not test_bad'" else ""; |
There was a problem hiding this comment.
pyTestArgs is not a valid argument for buildPythonPackage. Use a let expression instead.
There was a problem hiding this comment.
You're right, that should've been a let expression. I merged a bit too quick. The way it is now should just add a pyTestArgs environment variable though, or does buildPythonPackage handle this different from mkDerivation? Do you want me to make a new PR to use let instead?
|
I didn't target python-unstable because of a large rebuild but because the issue was introduced in python-unstable (by the pytest upgrade, current head of python-unstable). |
|
And I originally noticed the regression on python-unstable because I based #49446 on python-unstable because it relies on the cython upgrade. By the time it is unblocked (when mesa is upgraded) that'll probably be in master though. |
Motivation for this change
The recent pytest upgrade in bea4b36
broke the test suite.
Originally part of #49446, but since it seems like that'll take a while its probably better to push this fix now.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)